Skip to content

DataViews: Add a lint rule preventing private API imports #81478

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ntsekouras merged 2 commits into from
Aug 24, 2026
Merged

DataViews: Add a lint rule preventing private API imports #81478

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
a14f938
DataViews: Add a lint rule preventing private API imports
ntsekouras Aug 12, 2026
4b871bf
remove entry from private-apis
ntsekouras Aug 24, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions packages/private-apis/CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,10 @@

## Unreleased

### Internal

- Remove `@wordpress/dataviews` from the list of core modules using private APIs, since importing private APIs is no longer allowed in the package. [#81478](https://github.com/WordPress/gutenberg/pull/81478)

## 1.53.0 (2026-08-12)

### Internal
Expand Down
1 change: 0 additions & 1 deletion packages/private-apis/src/implementation.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -42,7 +42,6 @@ const CORE_MODULES_USING_PRIVATE_APIS = [
'@wordpress/storybook',
'@wordpress/sync',
'@wordpress/theme',
'@wordpress/dataviews',
'@wordpress/fields',
'@wordpress/lazy-editor',
'@wordpress/media-editor',
Expand Down
20 changes: 20 additions & 0 deletions tools/eslint/config.mjs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -844,6 +844,26 @@ export default dedupePlugins( [
},
},

// Override: dataviews — restrict private-apis imports.
{
files: [ 'packages/dataviews/**' ],
rules: {
'no-restricted-imports': [
'error',
{
paths: [
...restrictedImports,
{
name: '@wordpress/private-apis',
message:
'dataviews is a bundled package that plugins may import via npm, where a second copy of private-apis cannot unlock objects locked by the WordPress copy and throws at runtime.',
},
],
},
],
},
},

// Override: edit-post, edit-site — restrict interface imports.
{
files: [ 'packages/edit-post/**', 'packages/edit-site/**' ],
Expand Down
Loading