Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions packages/block-library/CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -25,6 +25,7 @@
### Bug Fixes

- Footnotes: Treat unreadable `footnotes` post meta as no footnotes instead of throwing, so the block shows its placeholder rather than the block crash warning ([#81201](https://github.com/WordPress/gutenberg/pull/81201)).
- Playlist Track: Show the upload loading indicator inline with the track row.
- Playlist: Improve handling of declarative waveform player configuration ([#81342](https://github.com/WordPress/gutenberg/pull/81342)).
- Playlist: Update `@arraypress/waveform-player` to `^1.26.0`, disable automatic initialization, and prevent custom SVG icons from being configured through HTML data attributes.
- Cover: Pass `'full'` instead of `null` as the featured image size for parallax and repeated backgrounds, so a null array offset is no longer reached on PHP 8.5 ([#81444](https://github.com/WordPress/gutenberg/pull/81444)).
Expand Down
4 changes: 3 additions & 1 deletion packages/block-library/src/playlist-track/edit.js
Original file line number Diff line number Diff line change
Expand Up @@ -251,7 +251,6 @@ const PlaylistTrackEdit = ( {
</PanelBody>
</InspectorControls>
<li { ...blockProps }>
{ !! temporaryURL && <Spinner /> }
<button
className="wp-block-playlist-track__button"
onClick={ () => setCurrentTrackClientId( clientId ) }
Expand Down Expand Up @@ -300,6 +299,9 @@ const PlaylistTrackEdit = ( {
</span>
) }
{ length }
{ !! temporaryURL && (
<Spinner className="wp-block-playlist-track__spinner" />
) }
</span>
<span className="screen-reader-text">{ __( 'Play' ) }</span>
</button>
Expand Down
10 changes: 9 additions & 1 deletion packages/block-library/src/playlist-track/test/edit.js
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
import { fireEvent, render, screen } from '@testing-library/react';
import { fireEvent, render, screen, within } from '@testing-library/react';
import { useDispatch } from '@wordpress/data';
import PlaylistTrackEdit from '../edit';
import { PlaylistContext } from '../../playlist/context';
Expand Down Expand Up @@ -169,6 +169,7 @@ describe( 'PlaylistTrackEdit', () => {
renderEdit( {
attributes: {
blob: 'blob:https://example.com/temporary-track',
length: undefined,
src: undefined,
},
} );
Expand All @@ -178,6 +179,13 @@ describe( 'PlaylistTrackEdit', () => {
url: 'blob:https://example.com/temporary-track',
} )
);
const trackButton = screen.getByRole( 'button', {
name: /Song One/,
} );

expect(
within( trackButton ).getByRole( 'presentation', { hidden: true } )
).toBeInTheDocument();
} );

it( 'preserves the current track source when a replacement upload fails', () => {
Expand Down
Loading