Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions packages/block-library/CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -11,6 +11,7 @@
- Icon: Apply only padding to the inner SVG in the editor, so margin is no longer applied twice compared to the front end ([#81292](https://github.com/WordPress/gutenberg/pull/81292)).
- Playlist Track: Mark track media fields as content so toolbar inserters add an empty track instead of duplicating the selected track.
- Tabs: Number the generated tab IDs from 1 and keep them sequential, so IDs generated by other blocks on the page no longer shift the numbering ([#81781](https://github.com/WordPress/gutenberg/pull/81781)).
- Playlist: Stop sharing the parent "Add track" toolbar control with selected Playlist Track child blocks ([#81432](https://github.com/WordPress/gutenberg/pull/81432)).
- Term Description: Apply the term description display filters when rendering with term context inside a Terms Query loop, so multi-paragraph descriptions keep their paragraphs and match the taxonomy archive rendering ([#81290](https://github.com/WordPress/gutenberg/pull/81290)).
- Accordion: Resolve the URL fragment with the `:target` pseudo-class instead of decoding `window.location.hash`, so a hash containing malformed percent-encoding no longer throws a `URIError` when a panel is opened ([#81780](https://github.com/WordPress/gutenberg/pull/81780)).

Expand Down
1 change: 0 additions & 1 deletion packages/block-library/src/playlist/block.json
Original file line number Diff line number Diff line change
Expand Up @@ -69,7 +69,6 @@
"supports": {
"anchor": true,
"align": true,
"__experimentalExposeControlsToChildren": true,
Comment thread
scruffian marked this conversation as resolved.
"color": {
"gradients": true,
"link": true,
Expand Down
2 changes: 1 addition & 1 deletion packages/block-library/src/playlist/edit.js
Original file line number Diff line number Diff line change
Expand Up @@ -471,7 +471,7 @@ const PlaylistEdit = ( {

return (
<>
<BlockControls group="other" __experimentalShareWithChildBlocks>
<BlockControls group="other">
<MediaReplaceFlow
name={ __( 'Add track' ) }
onSelect={ onAddTracks }
Expand Down
47 changes: 0 additions & 47 deletions test/e2e/specs/editor/blocks/playlist.spec.js
Original file line number Diff line number Diff line change
Expand Up @@ -31,53 +31,6 @@ test.describe( 'Playlist block', () => {
await requestUtils.deleteAllMedia();
} );

test( 'shows the add track control when a playlist track is selected', async ( {
admin,
editor,
page,
} ) => {
await admin.createNewPost();
await expect( editor.canvas.locator( 'body' ) ).toBeVisible();
await page.waitForFunction(
() => window?.wp?.blocks && window?.wp?.data
);

await page.evaluate( ( audio ) => {
const track = window.wp.blocks.createBlock( 'core/playlist-track', {
id: audio.id,
src: audio.source_url,
title: 'Selected Track',
artist: 'Test Artist',
length: '0:12',
} );
const playlist = window.wp.blocks.createBlock(
'core/playlist',
{},
[ track ]
);

window.wp.data
.dispatch( 'core/block-editor' )
.insertBlock( playlist );
window.wp.data
.dispatch( 'core/block-editor' )
.selectBlock( track.clientId );
}, uploadedAudio );

await expect(
editor.canvas
.locator( '[data-type="core/playlist-track"].is-selected' )
.first()
).toBeVisible();
await editor.showBlockToolbar();

await expect(
page
.getByRole( 'toolbar', { name: 'Block tools' } )
.getByRole( 'button', { name: 'Add track' } )
).toBeVisible();
} );

test( 'waveform seek control can be reached and operated with the keyboard on the frontend', async ( {
page,
requestUtils,
Expand Down
Loading