Repository navigation
Remove content types experiment #81340
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 3 commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
731 changes: 0 additions & 731 deletions
731
lib/experimental/content-types/class-wp-rest-user-post-types-controller-gutenberg.php
This file was deleted.
Oops, something went wrong.
604 changes: 0 additions & 604 deletions
604
lib/experimental/content-types/class-wp-rest-user-taxonomies-controller-gutenberg.php
This file was deleted.
Oops, something went wrong.
This file was deleted.
Oops, something went wrong.
This file was deleted.
Oops, something went wrong.
This file was deleted.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One thing we don't really do much about here is the relevant data that remains in the database. It will remain there forever, and there's no "user" way to clean it up. I wonder if we should offer something that warns users removal will happen, and cleans up. We don't have to do anything, since this is an experiment, I imagine that's fine, but also wanted to agree on this before we go ahead. Potential cleanup would have to mean cleaning up:
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It was an experiment and IMO is better not to try to auto delete data. The most important reason is that since this was an early experiment it could lack proper validation (especially in the very first iterations) and trying to delete posts or terms created under cpts or custom taxonomies could conflict with existing ones. A theoretical example could be create
product cpt -> deactivate -> install Woo and create products -> deactivate Woo. That scenario could possibly delete products that were actually created while using Woo, and the user could activate that plugin again in the future.I think the safest script would be to delete cpts and custom taxonomies, the
_gutenberg_user_content_types_flush_rewrite_rulesoption and trigger the update of rewrite rules flush. Something like this:I can add this in the clossing comment for the main issue and share in core editor slack. What do you think?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yup, I think that should suffice, sounds good!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't think we've ever shipped a cleanup notice for experiments. It's usually better to leave this to site admins; WP CLI is better at cleaning up similar leftovers.