Repository navigation
fix: Fixes HEIC uploads hanging indefinitely when ImageDecoder stalls #81211
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
singhakanshu00
wants to merge
11
commits into
WordPress:trunk
from
singhakanshu00:fix/heic-upload-hang-issue
Closed
Changes from 6 commits
Commits
Show all changes
11 commits
Select commit
Hold shift + click to select a range
b78794f
fix: Fixes HEIC uploads hanging indefinitely when ImageDecoder stalls
singhakanshu00 ade225c
Merge branch 'trunk' into fix/heic-upload-hang-issue
adamsilverstein 226431e
Merge branch 'trunk' into fix/heic-upload-hang-issue
singhakanshu00 66ea844
fix: Fixes empty file type issue in OS that lacks OS-Level codec
singhakanshu00 67c16e5
feat: Captures timeoutId and clear in the finally
singhakanshu00 748775a
Merge branch 'trunk' into fix/heic-upload-hang-issue
singhakanshu00 25ad997
Merge branch 'trunk' into fix/heic-upload-hang-issue
t-hamano 9991048
fix: Detect untyped HEIC uploads from the file header instead of the …
t-hamano 5f177a2
fix: Skip the ImageDecoder strategy for files with no MIME type
t-hamano 3230dc5
docs: Add an upload-media changelog entry for the HEIC upload fix
t-hamano caf0939
Merge branch 'trunk' into fix/heic-upload-hang-issue
adamsilverstein File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I believe inferring file extensions from filenames is unreliable. It might be more accurate to determine if it's an HEIC image from the file buffer, similar to how
isAnimatedGifmight work.The following code was generated by AI and has not been tested. @adamsilverstein might have more insights into this area.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fixed in 9991048