Repository navigation
CI: build once and reuse the build across e2e tests shards #81031
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
7 commits
Select commit
Hold shift + click to select a range
37e49fe
E2E tests: build once and reuse the build across shards
adimoldovan b143304
Rename the build job to Build
adimoldovan 38887f9
Upload the build output directly instead of tarring it
adimoldovan d8a68e8
Merge branch 'trunk' into e2e-tests-worflow-build-one-and-reuse
adimoldovan ac808be
Merge remote-tracking branch 'origin/trunk' into e2e-tests-worflow-bu…
adimoldovan 811be6d
Merge branch 'trunk' into e2e-tests-worflow-build-one-and-reuse
adimoldovan 56892e6
Reduce build artifact retention to 3 days
adimoldovan File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@adimoldovan It looks like
needs.<job_id>.resultcan be eithersuccess,failure,cancelled, orskipped.! cancelled()checks that the workflow run itself has not been cancelled and coverscancelled.result != 'skippedcovers whenbuildis skilled entirely.That leaves
failureandsuccess.I'm not clear on why this conditional check is necessary. If the
buildjob fails, wouldn't the workflow run be stopped and all steps/jobs following the failure never run?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If the build job fails the dependent e2e jobs will be skipped and a skipped job that is required will not block the merge. #81015 will make this step irrelevant though (and this reminded me to update it).