Repository navigation
Conversation
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01GQNdFF1FUU9JXfNGZev2na
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01GQNdFF1FUU9JXfNGZev2na
50 of 89 tasks
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
|
Size Change: +19 B (0%) Total Size: 7.76 MB 📦 View Changed
|
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01GQNdFF1FUU9JXfNGZev2na
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01GQNdFF1FUU9JXfNGZev2na
…inner-blocks # Conflicts: # test/e2e/specs/editor/various/copy-cut-paste.spec.js
27 of 81 tasks
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What?
Fixes #26713. Pasting a block that has inner blocks into text no longer drops the inner blocks: a copied list item keeps its nested list.
Why?
__unstableSplitSelectionmerges the first and last pasted blocks into the surrounding text (introduced in #54543), but the merge only joins attributes: the merged blocks' inner blocks were discarded. This is the paste-side counterpart of #77245, which fixed the merge machinery dropping children on Delete. It also dropped a split half whose attributes were untouched even when it still held children, losing the target's own nested list when pasting at the end of an item.How?
The head and tail merges carry over the merged block's inner blocks, and an attribute-unmodified tail is kept when it still has children. Following the rule from #78776: the head never carries the first block's own inner blocks, since they sit after its text — within a ranged selection they are deleted with it, and for a collapsed selection they belong to the trailing half.
When pasting at the end of an item whose children belonged to the trailing half, those children now survive on an empty trailing item. Reattaching them to the preceding item would be a separate reparenting decision.
Testing Instructions
Covered by regression tests for both the caret and the ranged selection case; they fail on trunk.
Use of AI Tools
Written with Claude Code, reviewed and tested by me.