Skip to content

Writing flow: forward delete an empty paragraph without breaking apart the next block #80813

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ellatrix merged 3 commits into from
Jul 29, 2026
Merged

Writing flow: forward delete an empty paragraph without breaking apart the next block #80813

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
9b40d58
Remove an unmodified default block on forward delete instead of break…
ellatrix Jul 28, 2026
7feab5b
Add a regression test for forward deleting an empty paragraph before …
ellatrix Jul 28, 2026
0847982
Assert the setup before the forward delete
ellatrix Jul 28, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 17 additions & 1 deletion packages/block-editor/src/components/block-list/block.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -464,7 +464,23 @@ const applyWithDispatch = withDispatch( ( dispatch, ownProps, registry ) => {
return;
}

if ( getBlockOrder( nextBlockClientId ).length ) {
// Forward deleting an unmodified default block should
// remove it and move into the next block, not pull the
// next block's first item out of it.
if ( isUnmodifiedDefaultBlock( getBlock( clientId ) ) ) {
// Select the first leaf block, so the caret starts at
// the beginning of the block's content rather than on
// a container's shell.
let firstLeafClientId = nextBlockClientId;
while ( getBlockOrder( firstLeafClientId ).length ) {
firstLeafClientId =
getBlockOrder( firstLeafClientId )[ 0 ];
}
registry.batch( () => {
removeBlock( clientId );
selectBlock( firstLeafClientId );
} );
} else if ( getBlockOrder( nextBlockClientId ).length ) {
moveFirstItemUp( nextBlockClientId, false );
} else {
mergeBlocks( clientId, nextBlockClientId );
Expand Down
56 changes: 56 additions & 0 deletions test/e2e/specs/editor/various/splitting-merging.spec.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -277,6 +277,62 @@ test.describe( 'splitting and merging blocks (@firefox, @webkit)', () => {
] );
} );

test( 'should forward delete an empty paragraph without breaking apart the next block', async ( {
editor,
page,
} ) => {
await editor.insertBlock( { name: 'core/paragraph' } );
await editor.insertBlock( {
name: 'core/list',
innerBlocks: [
{ name: 'core/list-item', attributes: { content: 'one' } },
{ name: 'core/list-item', attributes: { content: 'two' } },
],
} );

await editor.canvas
.getByRole( 'document', { name: 'Empty block' } )
.click();

await expect.poll( editor.getBlocks ).toMatchObject( [
{ name: 'core/paragraph', attributes: { content: '' } },
{
name: 'core/list',
innerBlocks: [
{
name: 'core/list-item',
attributes: { content: 'one' },
},
{
name: 'core/list-item',
attributes: { content: 'two' },
},
],
},
] );

await page.keyboard.press( 'Delete' );
await page.keyboard.type( '|' );

// The empty paragraph is removed and the list is left intact, with
// the caret at the start of its first item.
await expect.poll( editor.getBlocks ).toMatchObject( [
{
name: 'core/list',
innerBlocks: [
{
name: 'core/list-item',
attributes: { content: '|one' },
},
{
name: 'core/list-item',
attributes: { content: 'two' },
},
],
},
] );
} );

test( 'should remove empty paragraph block on backspace', async ( {
editor,
page,
Expand Down
Loading