Skip to content

Remove redundant @jest-environment jsdom pragma and lint against it #80676

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
manzoorwanijk merged 2 commits into from
Jul 24, 2026
Merged

Remove redundant @jest-environment jsdom pragma and lint against it #80676

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
fc5c087
Remove redundant @jest-environment jsdom pragma and lint against it
manzoorwanijk Jul 24, 2026
db08dcc
Fix comment formatting
manzoorwanijk Jul 24, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 0 additions & 4 deletions packages/block-library/src/navigation/test/view.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,3 @@
/**
* @jest-environment jsdom
*/

let mockRegisteredStore;
let mockCurrentContext;

Expand Down
14 changes: 14 additions & 0 deletions tools/eslint/config.mjs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -486,6 +486,20 @@ export default dedupePlugins( [
'test/performance/**/*.[tj]s?(x)',
'test/storybook-playwright/**/*.[tj]s?(x)',
],
rules: {
...jestPlugin.configs[ 'flat/recommended' ].rules,
/*
* `jsdom` is already the default test environment in `@wordpress/jest-preset-default`,
* so the docblock pragma is redundant.
*/
'no-warning-comments': [
Comment thread
manzoorwanijk marked this conversation as resolved.
'error',
{
terms: [ '@jest-environment jsdom' ],
location: 'anywhere',
},
],
},
},

// Override: E2E test files (non-Playwright).
Expand Down
Loading