Repository navigation
Automated Testing: Add Storybook component documentation regression testing #80655
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
12 commits
Select commit
Hold shift + click to select a range
5e35190
Automated Testing: Add Storybook component documentation regression t…
aduth e21e887
Add and fix type-checking for Storybook package scripts
aduth 108ee2f
Sync components manifest
aduth 18505b3
Automated Testing: Clarify distinction of manifest diff vs check-loca…
aduth 53ec48d
Storybook: Simplify to reuse internal Storybook manifest types
aduth c0aa397
Align js-yaml types to major version of runtime package
aduth 4fe36ff
Storybook: Normalize manifest output with Prettier
aduth fa11fe7
Update components-manifest.yml
aduth 1ad4a45
design-system-mcp: Restore MCP manifest validation script
aduth a2c4268
Automated Testing: Prefix parent component name for subcomponents
aduth 23baa87
Sync manifest
aduth 8ac4670
Alphabetize dependencies
aduth File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is it ok that we're removing the smoke test on
parseComponents?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah in my mind the
validate-manifest.mjswas an initial-but-naive implementation of what this new snapshot approach handles more holistically. The previous script just checked that some components exist and are parseable, and was introduced originally to help protect against shape changes in the manifest. Since the new snapshot will similarly break when there are shape changes, it will serve as equal protection.Although, now that I think of it, it could still have some value insofar as extending that coverage to how
@wordpress/design-system-mcpparses the manifest, since that's separate logic that would also need to be updated. Maybe it's best to restore it after all 🙂Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Restored the MCP validation in ccfc8f8.