Repository navigation
Components: Migrate ZStack styles from Emotion to SCSS module #80514
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
ciampo
merged 15 commits into
WordPress:trunk
from
im3dabasia:migrate/z-stack-to-module-scss
Aug 25, 2026
Merged
Changes from 9 commits
Commits
Show all changes
15 commits
Select commit
Hold shift + click to select a range
62f79e6
Components: Migrate ZStack styles from Emotion to SCSS module
im3dabasia 6f50a42
Add changelog entry for ZStack SCSS migration
im3dabasia 3247e32
Chore: Remove suppresion
im3dabasia d4f5253
Merge branch 'trunk' into migrate/z-stack-to-module-scss
im3dabasia 427e2e8
fix: Work on feedbakcs
im3dabasia 1c7e37b
chore: Remove changelog
im3dabasia f855831
chore: Remove changelog
im3dabasia ae122f1
Merge branch 'trunk' into migrate/z-stack-to-module-scss
im3dabasia a92baf7
docs: Add changelog entry
im3dabasia 358ddee
Merge branch 'trunk' into migrate/z-stack-to-module-scss
im3dabasia 7ea918e
fix: give layered child class to level specificty
im3dabasia 14f069c
Merge branch 'trunk' into migrate/z-stack-to-module-scss
im3dabasia 623785a
fix: maintain z-index specifity as it were in emotion
im3dabasia 79c215e
Merge branch 'trunk' into migrate/z-stack-to-module-scss
im3dabasia 20169d5
chore: add log
im3dabasia File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,20 @@ | ||
| .z-stack { | ||
| display: inline-grid; | ||
| grid-auto-flow: column; | ||
| position: relative; | ||
|
|
||
| > .child { | ||
| position: relative; | ||
| justify-self: start; | ||
| } | ||
|
|
||
| // When the ZStack is layered, all items overlap in the same grid cell. | ||
| &.layered > .child { | ||
| grid-row-start: 1; | ||
| grid-column-start: 1; | ||
| } | ||
|
im3dabasia marked this conversation as resolved.
Resolved
|
||
| } | ||
|
|
||
| .child:not(:first-of-type) { | ||
| margin-inline-start: var(--z-stack-offset, 0); | ||
| } | ||
This file was deleted.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This moves
z-indexfrom a CSS rule to an inline style. Inline styles win over consumer CSS, so styles that previously changed the child stacking order will stop working.Could we pass the value through a custom property and set
z-indexin the.childrule? This keeps the value dynamic without changing the cascade.