Repository navigation
Conversation
mirka
force-pushed
the
fix/fork-changelog-base-fetch
branch
from
July 20, 2026 18:28
b2cb320 to
870c6c6
Compare
Member
Author
|
Superseded by #80538, which retains the baseline, fix, and cleanup commits along with both workflow runs. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What?
Fixes the optional package changelog workflow to fetch the base branch history from the base repository instead of the pull request author's fork.
Why?
When a pull request comes from a fork whose
trunkbranch is behind upstream, the current fetch may not include the pull request's base SHA. The subsequent three-dot diff cannot resolve the merge base and may incorrectly skip the changelog check. This occurred in #80472.How?
Fetches the base branch from
$GITHUB_SERVER_URL/$GITHUB_REPOSITORY.git. These variables identify the repository running the workflow, so forked and same-repository pull requests use the upstream base history consistently.Testing Instructions
This was tested in the draft PR by adding and then removing a temporary file under
packages/components. Both testing commits are retained in the PR history.trunkfromWordPress/gutenberg.Please add a CHANGELOG entry to packages/components/CHANGELOG.mdinstead of skipping due to an invalid diff.