Skip to content

Remove __shouldNotWarnDeprecated36pxSize internal prop #80323

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mirka merged 2 commits into from
Jul 17, 2026
Merged

Remove __shouldNotWarnDeprecated36pxSize internal prop #80323

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
b751d08
Remove __shouldNotWarnDeprecated36pxSize internal prop.
mirka Jul 15, 2026
6e8229a
Add changelog
mirka Jul 17, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions packages/components/CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,6 +13,7 @@
### Internal

- `ConfirmDialog`: Migrate styles from Emotion to an SCSS Module ([#80394](https://github.com/WordPress/gutenberg/pull/80394)).
- `InputControl`, `SelectControl`, `CustomSelectControl`, `ToggleGroupControl`, and `RangeControl`: Remove obsolete internal `__shouldNotWarnDeprecated36pxSize` prop ([#80323](https://github.com/WordPress/gutenberg/pull/80323)).

@ciampo ciampo Jul 17, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I know it's only a type and it probably has no usage, but we've received complaints in the past about introducing type errors. Should we keep the prop around as no-op? Or should we flag it as breaking change?

@mirka mirka Jul 17, 2026

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That is what I initially assumed, but after doing a final audit for things we could clean up, I realized that this prop was never even documented publicly. (The problem with removing types for __next40pxDefaultSize was that it was not only publicly documented, but that we were actively asking everyone to use it.)

So I think it's safe to consider this a completely internal thing.

- `InputControl`, `SelectControl`, `CustomSelectControl`: Remove obsolete `__unstable-large` from the public `size` type. The value continues to work at runtime, and is equivalent to the `default` size. ([#80081](https://github.com/WordPress/gutenberg/pull/80081)).
- Update `exports` to use subpath patterns instead of deprecated trailing `/` folder mappings ([#80270](https://github.com/WordPress/gutenberg/pull/80270)).

Expand Down
1 change: 0 additions & 1 deletion packages/components/src/custom-select-control/index.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -62,7 +62,6 @@ function CustomSelectControl< T extends CustomSelectOption >(
const {
// Prevent passing legacy props to internal component.
__next40pxDefaultSize: _next40pxDefaultSize,
__shouldNotWarnDeprecated36pxSize: _shouldNotWarnDeprecated36pxSize,
describedBy,
options,
onChange,
Expand Down
7 changes: 0 additions & 7 deletions packages/components/src/custom-select-control/types.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -121,11 +121,4 @@ export type CustomSelectProps< T extends CustomSelectOption > = {
* @ignore
*/
__next40pxDefaultSize?: boolean;
/**
* Do not throw a warning for the deprecated 36px default size.
* For internal components of other components that already throw the warning.
*
* @ignore
*/
__shouldNotWarnDeprecated36pxSize?: boolean;
};
1 change: 0 additions & 1 deletion packages/components/src/input-control/index.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,7 +37,6 @@ export function UnforwardedInputControl(
// Prevent passing legacy props to internal components.
__next40pxDefaultSize: _next40pxDefaultSize,
__next36pxDefaultSize: _next36pxDefaultSize,
__shouldNotWarnDeprecated36pxSize: _shouldNotWarnDeprecated36pxSize,
__unstableStateReducer: stateReducer = ( state ) => state,
__unstableInputWidth,
className,
Expand Down
7 changes: 0 additions & 7 deletions packages/components/src/input-control/types.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -199,13 +199,6 @@ export interface InputControlProps
* @ignore
*/
__next40pxDefaultSize?: boolean;
/**
* Do not throw a warning for the deprecated 36px default size.
* For internal components of other components that already throw the warning.
*
* @ignore
*/
__shouldNotWarnDeprecated36pxSize?: boolean;
__unstableStateReducer?: InputFieldProps[ 'stateReducer' ];
}

Expand Down
1 change: 0 additions & 1 deletion packages/components/src/range-control/index.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -68,7 +68,6 @@ function UnforwardedRangeControl(
// Prevent passing legacy props to internal component.
__nextHasNoMarginBottom: _,
__next40pxDefaultSize: _next40pxDefaultSize,
__shouldNotWarnDeprecated36pxSize: _shouldNotWarnDeprecated36pxSize,
afterIcon,
allowReset = false,
beforeIcon,
Expand Down
8 changes: 0 additions & 8 deletions packages/components/src/range-control/types.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -225,14 +225,6 @@ export type RangeControlProps = Pick<
* @default true
*/
withInputField?: boolean;
/**
* Do not throw a warning for the deprecated 36px default size.
* For internal components of other components that already throw the warning.
*
* @deprecated Default behavior since WordPress 7.1. Prop can be safely removed.
* @ignore
*/
__shouldNotWarnDeprecated36pxSize?: boolean;
};

export type RailProps = MarksProps & {
Expand Down
1 change: 0 additions & 1 deletion packages/components/src/select-control/index.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -50,7 +50,6 @@ function UnforwardedSelectControl< V extends string >(
__nextHasNoMarginBottom: _,
__next40pxDefaultSize: _next40pxDefaultSize,
__next36pxDefaultSize: _next36pxDefaultSize,
__shouldNotWarnDeprecated36pxSize: _shouldNotWarnDeprecated36pxSize,
className,
disabled = false,
help,
Expand Down
7 changes: 0 additions & 7 deletions packages/components/src/select-control/types.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,13 +35,6 @@ type SelectControlBaseProps< V extends string > = Pick<
* @ignore
*/
__next40pxDefaultSize?: boolean;
/**
* Do not throw a warning for the deprecated 36px default size.
* For internal components of other components that already throw the warning.
*
* @ignore
*/
__shouldNotWarnDeprecated36pxSize?: boolean;
/**
* An array of option property objects to be rendered,
* each with a `label` and `value` property, as well as any other
Expand Down
1 change: 0 additions & 1 deletion packages/components/src/toggle-group-control/toggle-group-control/component.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,7 +32,6 @@ function UnconnectedToggleGroupControl(
__nextHasNoMarginBottom: _,
size: _size,
__next40pxDefaultSize: _next40pxDefaultSize,
__shouldNotWarnDeprecated36pxSize: _shouldNotWarnDeprecated36pxSize,
className,
isAdaptiveWidth = false,
isBlock = false,
Expand Down
7 changes: 0 additions & 7 deletions packages/components/src/toggle-group-control/types.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -130,13 +130,6 @@ export type ToggleGroupControlProps = Pick<
* @ignore
*/
__next40pxDefaultSize?: boolean;
/**
* Do not throw a warning for the deprecated 36px default size.
* For internal components of other components that already throw the warning.
*
* @ignore
*/
__shouldNotWarnDeprecated36pxSize?: boolean;
};

export type ToggleGroupControlContextProps = {
Expand Down
Loading