Skip to content
Merged
Show file tree
Hide file tree
Changes from 8 commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 12 additions & 2 deletions .github/workflows/upload-release-to-plugin-repo.yml
Comment thread
ciampo marked this conversation as resolved.
Resolved
Original file line number Diff line number Diff line change
Expand Up @@ -260,7 +260,12 @@ jobs:
runs-on: 'ubuntu-24.04'
permissions: {}
environment: wp.org plugin
needs: [compute-should-update-trunk, update-changelog, get-release-metadata]
needs:
[
compute-should-update-trunk,
update-changelog,
get-release-metadata,
]
if: |
needs.compute-should-update-trunk.outputs.should_update_trunk == 'true' && needs.get-release-metadata.outputs.plugin_asset_url
env:
Expand Down Expand Up @@ -343,7 +348,12 @@ jobs:
runs-on: 'ubuntu-24.04'
permissions: {}
environment: wp.org plugin
needs: [compute-should-update-trunk, update-changelog, get-release-metadata]
needs:
[
compute-should-update-trunk,
update-changelog,
get-release-metadata,
]
if: |
needs.compute-should-update-trunk.outputs.should_update_trunk == 'false' && needs.get-release-metadata.outputs.plugin_asset_url
env:
Expand Down
1 change: 1 addition & 0 deletions packages/dataviews/CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -9,6 +9,7 @@
### Bug Fix

- DataViews: Stop the infinite-scroll list from jumping while pages load asynchronously. The scroll-anchor restoration no longer discards scrolling the user did during the load, and the footer's visibility no longer depends on the loading state, so it no longer mounts mid-load (resizing the scroll container). [#79546](https://github.com/WordPress/gutenberg/pull/79546)
- Fix Dataviews popover hover text color readability issue on WordPress 7.0. [#80105](https://github.com/WordPress/gutenberg/pull/80105)

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We'll need to rebase the PR on top of latest trunk and move this entry under the Unreleased section, given that a new version of the npm packages was released in the meantime.


### Internal

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -198,6 +198,7 @@
cursor: default;
min-height: var(--wpds-dimension-size-md);
@include body-medium();
color: var(--wpds-color-foreground-interactive-neutral);

&:last-child {
margin-block-end: 0;
Expand All @@ -207,6 +208,7 @@
&[data-active-item],
&:focus {
background-color: var(--wpds-color-background-interactive-brand-weak-active);
color: var(--wpds-color-foreground-interactive-neutral-active);

.dataviews-filters__search-widget-listitem-single-selection {
border-color: var(--wpds-color-stroke-interactive-brand-active);
Expand All @@ -226,6 +228,10 @@
background: var(--wpds-color-background-interactive-brand-strong-active);
}
}

.dataviews-filters__search-widget-listitem-description {
color: var(--wpds-color-foreground-interactive-neutral-weak-active);
}
}

.dataviews-filters__search-widget-listitem-value {
Expand All @@ -241,7 +247,7 @@
text-overflow: ellipsis;
font-size: var(--wpds-typography-font-size-sm);
line-height: 16px;
color: var(--wpds-color-foreground-content-neutral-weak);
color: var(--wpds-color-foreground-interactive-neutral-weak);
}

.dataviews-filters__search-widget-listitem-single-selection {
Expand Down
Loading