Repository navigation
DS: Name font weight tokens by intent #80093
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from all commits
4f0caad
ecde8d2
3070b47
962e866
b9d8cf8
25f9b0d
d4a19ab
617dd1a
a91484e
4a65933
f84c7be
00f30c1
6a7c8b3
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -12,7 +12,11 @@ | |
| * Fonts & basic variables. | ||
| */ | ||
|
|
||
| $default-font: -apple-system, BlinkMacSystemFont,"Segoe UI", Roboto, Oxygen-Sans, Ubuntu, Cantarell,"Helvetica Neue", sans-serif; // Todo: deprecate in favor of $family variables | ||
| $font-family-headings: -apple-system, system-ui, "Segoe UI", Roboto, Oxygen-Sans, Ubuntu, Cantarell, "Helvetica Neue", sans-serif; | ||
| $font-family-body: -apple-system, system-ui, "Segoe UI", Roboto, Oxygen-Sans, Ubuntu, Cantarell, "Helvetica Neue", sans-serif; | ||
| $font-family-mono: Menlo, Consolas, monaco, monospace; | ||
|
|
||
| $default-font: $font-family-body; // Todo: deprecate in favor of $family variables | ||
| $default-line-height: 1.4; // Todo: deprecate in favor of $line-height tokens | ||
|
|
||
| /** | ||
|
|
@@ -35,15 +39,6 @@ $font-line-height-large: 28px; | |
| $font-line-height-x-large: 32px; | ||
| $font-line-height-2x-large: 40px; | ||
|
|
||
| // Weights | ||
| $font-weight-regular: 400; | ||
| $font-weight-medium: 499; // ensures fallback to 400 (instead of 600) | ||
|
Comment on lines
-38
to
-40
Member
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I was worried this would impact
Contributor
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. We should also reconcile those, yes
Contributor
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. |
||
|
|
||
| // Families | ||
| $font-family-headings: -apple-system, "system-ui", "Segoe UI", Roboto, Oxygen-Sans, Ubuntu, Cantarell, "Helvetica Neue", sans-serif; | ||
| $font-family-body: -apple-system, "system-ui", "Segoe UI", Roboto, Oxygen-Sans, Ubuntu, Cantarell, "Helvetica Neue", sans-serif; | ||
| $font-family-mono: Menlo, Consolas, monaco, monospace; | ||
|
|
||
| /** | ||
| * Grid System. | ||
| * https://make.wordpress.org/design/2019/10/31/proposal-a-consistent-spacing-system-for-wordpress/ | ||
|
|
||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,5 +1,3 @@ | ||
| @use "@wordpress/base-styles/variables"; | ||
|
|
||
| .block-editor-block-quick-navigation__item { | ||
| font-weight: variables.$font-weight-regular; | ||
| font-weight: var(--wpds-typography-font-weight-default); | ||
| } |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
While at it, I also updated the font family stacks to replicate the
@wordpress/themevalue