remove unnecessary default prop from test (inserter/test/menu.js) #7984
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
See https://github.com/WordPress/gutenberg/pull/7773/files#r202718599 for comment raising this issue. There is no necessity for this prop to be set because we aren’t testing anything explicitly requiring that prop. Originally it was intended to mock the `instanceId` prop provided by the `withInstanceId` HOC but was implemented with an incorrect name. As mentioned, its not needed at all so just removing.
nerrad
added
[Type] Automated Testing
4 tasks
aduth
approved these changes
Jul 16, 2018
gziolo
deleted the
fix/remove-unnecessary-prop-from-test-(inserter-menu.js)
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
See https://github.com/WordPress/gutenberg/pull/7773/files#r202718599 for comment raising this issue. There is no necessity for this prop to be set because we aren’t testing anything explicitly requiring that prop. Originally it was intended to mock the
instanceIdprop provided by thewithInstanceIdHOC but was implemented with an incorrect name. As mentioned, its not needed at all so just removing.How has this been tested?
Checklist: