Skip to content
Merged
Show file tree
Hide file tree
Changes from 4 commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions packages/components/CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,7 @@

### Breaking Changes

- `ExternalLink`: No longer adds `noopener` to the `rel` attribute. Consumers relying on the previous behavior should pass `rel="noopener"` explicitly ([#79743](https://github.com/WordPress/gutenberg/pull/79743)).
- The `__next40pxDefaultSize` prop is now true by default. The prop can be safely removed from the following:
- `BorderBoxControl` ([#79420](https://github.com/WordPress/gutenberg/pull/79420))
- `BorderControl` ([#79418](https://github.com/WordPress/gutenberg/pull/79418))
Expand Down
4 changes: 1 addition & 3 deletions packages/components/src/external-link/index.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -25,9 +25,7 @@ function UnforwardedExternalLink(
) {
const { href, children, className, rel = '', ...additionalProps } = props;
const optimizedRel = [
...new Set(
[ ...rel.split( ' ' ), 'external', 'noopener' ].filter( Boolean )
),
...new Set( [ ...rel.split( ' ' ), 'external' ].filter( Boolean ) ),
Comment thread
ciampo marked this conversation as resolved.
Resolved
].join( ' ' );
const classes = clsx( 'components-external-link', className );
/* Anchor links are perceived as external links.
Expand Down
49 changes: 49 additions & 0 deletions packages/components/src/external-link/test/index.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -10,6 +10,55 @@ import userEvent from '@testing-library/user-event';
import { ExternalLink } from '..';

describe( 'ExternalLink', () => {
test( 'should set external rel token', () => {
render(
<ExternalLink href="https://wordpress.org">
WordPress.org
</ExternalLink>
);

expect(
screen.getByRole( 'link', {
name: 'WordPress.org (opens in a new tab)',
} )
).toHaveAttribute( 'rel', 'external' );
} );

test( 'should preserve custom rel tokens', () => {
render(
<ExternalLink href="https://wordpress.org" rel="nofollow">
WordPress.org
</ExternalLink>
);

expect(
screen.getByRole( 'link', {
name: 'WordPress.org (opens in a new tab)',
} )
).toHaveAttribute( 'rel', 'nofollow external' );
} );

test( 'should not add noreferrer or noopener rel tokens', () => {
render(
<ExternalLink href="https://wordpress.org">
WordPress.org
</ExternalLink>
);

const link = screen.getByRole( 'link', {
name: 'WordPress.org (opens in a new tab)',
} );

expect( link ).not.toHaveAttribute(
'rel',
expect.stringContaining( 'noreferrer' )
);
expect( link ).not.toHaveAttribute(
'rel',
expect.stringContaining( 'noopener' )
);
} );

Comment thread
ciampo marked this conversation as resolved.
Resolved
test( 'should call function passed in onClick handler when clicking the link', async () => {
const user = await userEvent.setup();
const onClickMock = jest.fn();
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -91,7 +91,7 @@ exports[`PostPublishPanel should render the post-publish panel if the post is pu
<a
class="components-external-link"
href="https://wordpress.local/sample-page/"
rel="external noopener"
rel="external"
target="_blank"
>
<span
Expand Down Expand Up @@ -319,7 +319,7 @@ exports[`PostPublishPanel should render the post-publish panel if the post is sc
<a
class="components-external-link"
href="https://wordpress.local/sample-page/"
rel="external noopener"
rel="external"
target="_blank"
>
<span
Expand Down
40 changes: 40 additions & 0 deletions packages/ui/src/link/test/index.test.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -48,6 +48,46 @@ describe( 'Link', () => {
);
} );

it( 'does not set rel tokens when true', () => {
Comment thread
ciampo marked this conversation as resolved.
Resolved
render(
<Link href="https://example.com" openInNewTab>
External
</Link>
);

expect( screen.getByRole( 'link' ) ).not.toHaveAttribute( 'rel' );
} );

it( 'preserves custom rel tokens when true', () => {
render(
<Link href="https://example.com" openInNewTab rel="nofollow">
External
</Link>
);

expect( screen.getByRole( 'link' ) ).toHaveAttribute(
'rel',
'nofollow'
);
} );

it( 'does not add noreferrer or noopener when true', () => {
render(
<Link href="https://example.com" openInNewTab>
External
</Link>
);

expect( screen.getByRole( 'link' ) ).not.toHaveAttribute(
'rel',
expect.stringContaining( 'noreferrer' )
);
expect( screen.getByRole( 'link' ) ).not.toHaveAttribute(
'rel',
expect.stringContaining( 'noopener' )
);
} );

it( 'does not set target="_blank" when false', () => {
render( <Link href="https://example.com">External</Link> );

Expand Down
Loading