Skip to content

Build: Support --skip-types in npm run dev #79736

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
youknowriad merged 3 commits into from
Jul 1, 2026
Merged

Build: Support --skip-types in npm run dev #79736

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
5fb0fb9
Build: Support --skip-types in npm run dev
youknowriad Jul 1, 2026
2bfe1a1
Use parseArgs to read the --skip-types flag
youknowriad Jul 1, 2026
59f604a
Use parseArgs for --skip-types in the build script too
youknowriad Jul 1, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 8 additions & 1 deletion tools/build-scripts/build.mjs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,7 @@
*/
import spawn from 'cross-spawn';
import { fileURLToPath } from 'url';
import { parseArgs } from 'util';
import path from 'path';

const __dirname = path.dirname( fileURLToPath( import.meta.url ) );
Expand Down Expand Up @@ -78,7 +79,13 @@ function exec( command, args = [], options = {} ) {
* Main build orchestration function.
*/
async function build() {
const skipTypes = process.argv.includes( '--skip-types' );
const { values } = parseArgs( {
options: {
'skip-types': { type: 'boolean', default: false },
},
strict: false,
} );
const skipTypes = values[ 'skip-types' ];

console.log( '🔨 Starting build process...\n' );

Expand Down
67 changes: 41 additions & 26 deletions tools/build-scripts/dev.mjs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,7 @@
*/
import { execSync, spawn } from 'child_process';
import { fileURLToPath } from 'url';
import { parseArgs } from 'util';
import path from 'path';
import fs from 'fs';

Expand Down Expand Up @@ -114,6 +115,14 @@ const readyMarkerFile = {
* Main dev orchestration function.
*/
async function dev() {
const { values } = parseArgs( {
options: {
'skip-types': { type: 'boolean', default: false },
},
strict: false,
} );
const skipTypes = values[ 'skip-types' ];

console.log( '🔨 Starting development build...\n' );

const startTime = Date.now();
Expand Down Expand Up @@ -162,24 +171,26 @@ async function dev() {
path.join( __dirname, 'packages/generate-worker-placeholders.mjs' ),
] );

console.log( '\n📘 Building TypeScript types...\n' );
const tsStartTime = Date.now();
await exec( 'tsgo', [ '--build' ] ).catch( () => {
console.error(
'\n❌ TypeScript compilation failed. Try cleaning up first: `npm run clean:package-types`'
);
throw new Error( 'TypeScript compilation failed' );
} );
const buildTime = Date.now() - tsStartTime;
console.log( ` ✔ Built TypeScript types (${ buildTime }ms)` );

console.log( '\n✅ Checking type declaration files...' );
await exec( 'node', [
path.join(
__dirname,
'packages/check-build-type-declaration-files.cjs'
),
] );
if ( ! skipTypes ) {
console.log( '\n📘 Building TypeScript types...\n' );
const tsStartTime = Date.now();
await exec( 'tsgo', [ '--build' ] ).catch( () => {
console.error(
'\n❌ TypeScript compilation failed. Try cleaning up first: `npm run clean:package-types`'
);
throw new Error( 'TypeScript compilation failed' );
} );
const buildTime = Date.now() - tsStartTime;
console.log( ` ✔ Built TypeScript types (${ buildTime }ms)` );

console.log( '\n✅ Checking type declaration files...' );
await exec( 'node', [
path.join(
__dirname,
'packages/check-build-type-declaration-files.cjs'
),
] );
}

console.log( '\n📦 Building vendor files...' );
await exec( 'node', [
Expand All @@ -194,15 +205,19 @@ async function dev() {
);

console.log( '👀 Starting watch mode...\n' );
console.log( ' - TypeScript compiler watching for type changes' );
if ( ! skipTypes ) {
console.log( ' - TypeScript compiler watching for type changes' );
}
console.log( ' - Package builder watching for source changes\n' );

// Start TypeScript watch
const tscWatch = execAsync( 'tsgo', [
'--build',
'--watch',
'--preserveWatchOutput',
] );
// Start TypeScript watch (unless types are skipped).
const tscWatch = skipTypes
? null
: execAsync( 'tsgo', [
'--build',
'--watch',
'--preserveWatchOutput',
] );

// Start package build watch and wait for initial build to complete
// before signaling ready. wp-build outputs "Watching for changes..."
Expand All @@ -217,7 +232,7 @@ async function dev() {
// Handle process termination
const cleanup = () => {
console.log( '\n\n👋 Stopping watch mode...' );
tscWatch.kill();
tscWatch?.kill();
buildWatch.kill();
readyMarkerFile.cleanup();
process.exit( 0 );
Expand Down
Loading