Skip to content

TextIndentControl: Remove unnecessary __next40pxDefaultSize prop #79597

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mirka merged 6 commits into from
Jun 27, 2026
Merged

TextIndentControl: Remove unnecessary __next40pxDefaultSize prop #79597

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
60ddf68
TextIndentControl: Hard deprecate 40px default size
mirka Jun 26, 2026
f56b108
Add changelog
mirka Jun 26, 2026
e4dcab4
Remove __next40pxDefaultSize from internal TextIndentControl API
mirka Jun 26, 2026
414d99e
Remove changelog
mirka Jun 26, 2026
52b6438
Clean up
mirka Jun 26, 2026
26ff551
Fix __next40pxDefaultSize override via otherProps spread
mirka Jun 26, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion packages/block-editor/src/components/global-styles/typography-panel.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -693,7 +693,6 @@ export default function TypographyPanel( {
<TextIndentControl
value={ textIndent }
onChange={ setTextIndentValue }
size="__unstable-large"
__unstableInputWidth="auto"
withSlider
hasBottomMargin={ isGlobalStyles }
Expand Down
26 changes: 10 additions & 16 deletions packages/block-editor/src/components/text-indent-control/index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,19 +22,17 @@ import { useSettings } from '../../components/use-settings';
/**
* Control for line text indent.
*
* @param {Object} props Component props.
* @param {boolean} props.__next40pxDefaultSize Start opting into the larger default height that will become the default size in a future version.
* @param {string} props.value Currently selected text indent.
* @param {Function} props.onChange Handles change in text indent selection.
* @param {string|number|undefined} props.__unstableInputWidth Input width to pass through to inner UnitControl. Should be a valid CSS value.
* @param {boolean} props.withSlider Whether to show the slider control.
* @param {boolean} props.hasBottomMargin Whether to add bottom margin below the control.
* @param {string} props.help Help text to display below the control.
* @param {Object} props Component props.
* @param {string} props.value Currently selected text indent.
* @param {Function} props.onChange Handles change in text indent selection.
* @param {string|number|undefined} props.__unstableInputWidth Input width to pass through to inner UnitControl. Should be a valid CSS value.
* @param {boolean} props.withSlider Whether to show the slider control.
* @param {boolean} props.hasBottomMargin Whether to add bottom margin below the control.
* @param {string} props.help Help text to display below the control.
*
* @return {Element} Text indent control.
*/
export default function TextIndentControl( {
__next40pxDefaultSize = false,
value,
onChange,
__unstableInputWidth = '60px',
Expand Down Expand Up @@ -68,9 +66,8 @@ export default function TextIndentControl( {
if ( ! withSlider ) {
return (
<UnitControl
__next40pxDefaultSize={ __next40pxDefaultSize }
__shouldNotWarnDeprecated36pxSize
{ ...otherProps }
__next40pxDefaultSize
label={ __( 'Line indent' ) }
value={ value }
__unstableInputWidth={ __unstableInputWidth }
Expand All @@ -89,14 +86,12 @@ export default function TextIndentControl( {
<Flex>
<FlexItem isBlock>
<UnitControl
__next40pxDefaultSize={ __next40pxDefaultSize }
__shouldNotWarnDeprecated36pxSize
__next40pxDefaultSize
label={ __( 'Line indent' ) }
labelPosition="top"
hideLabelFromVision
value={ value }
onChange={ onChange }
size={ otherProps.size }
units={ units }
__unstableInputWidth={ __unstableInputWidth }
min={ 0 }
Expand All @@ -106,8 +101,7 @@ export default function TextIndentControl( {
<FlexItem isBlock>
<Spacer marginX={ 2 } marginBottom={ 0 }>
<RangeControl
__next40pxDefaultSize={ __next40pxDefaultSize }
__shouldNotWarnDeprecated36pxSize
__next40pxDefaultSize
label={ __( 'Line indent' ) }
hideLabelFromVision
value={ valueQuantity }
Expand Down
1 change: 1 addition & 0 deletions tools/eslint/config.mjs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -179,6 +179,7 @@ const restrictedSyntax = [
'QueryControls',
'SearchControl',
'TextControl',
'TextIndentControl',
'TreeSelect',
].map( ( componentName ) => ( {
selector: `JSXElement[openingElement.name.name="${ componentName }"] JSXAttribute[name.name="__next40pxDefaultSize"]`,
Expand Down
Loading