Skip to content

Media Fields: Avoid focus loss when detaching the current parent #79468

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Mamaduka merged 1 commit into from
Jun 24, 2026
Merged

Media Fields: Avoid focus loss when detaching the current parent #79468

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
34 changes: 17 additions & 17 deletions packages/media-fields/src/attached_to/edit.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -75,6 +75,7 @@ export default function MediaAttachedToEdit( {
post: 0,
_embedded: { ...data?._embedded, 'wp:attached-to': undefined },
} );
setValue( null );

@Mamaduka Mamaduka Jun 24, 2026

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rest the state early rather than waiting for a round trip.

setOptions( [] );
};

Expand Down Expand Up @@ -146,23 +147,22 @@ export default function MediaAttachedToEdit( {
}
};

const help = !! data.post
? createInterpolateElement(
__(
'Search for a post or page to attach this media to or <button>detach current</button>.'
),
{
button: (
<Button
__next40pxDefaultSize
onClick={ handleDetach }
variant="link"
accessibleWhenDisabled
/>
),
}
)
: __( 'Search for a post or page to attach this media to.' );
const help = createInterpolateElement(
__(
'Search for a post or page to attach this media to or <button>detach current</button>.'
),
{
button: (
<Button
__next40pxDefaultSize
onClick={ handleDetach }
variant="link"
accessibleWhenDisabled
disabled={ ! value }
/>
),
}
);

return (
<ComboboxControl
Expand Down
Loading