Skip to content

Site Editor: Introduce isHidden prop for SidebarNavigationItem #79352

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Mamaduka merged 2 commits into from
Jun 22, 2026
Merged

Site Editor: Introduce isHidden prop for SidebarNavigationItem #79352

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
d4dce99
Site Editor: Introduce `isHidden` prop for `SidebarNavigationItem`
Mamaduka Jun 18, 2026
ed41e5a
Avoid Styles item duplication
Mamaduka Jun 19, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 11 additions & 0 deletions packages/edit-site/src/components/sidebar-navigation-item/index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,6 +22,17 @@ import { SidebarNavigationContext } from '../sidebar';
const { useHistory, useLink, useLocation } = unlock( routerPrivateApis );

export default function SidebarNavigationItem( {
isHidden = false,

@Mamaduka Mamaduka Jun 19, 2026

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could find a better name, Claude tried as well 😄 I'm open for suggestions.

@t-hamano t-hamano Jun 22, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can't think of a more suitable name either 😄

...props
} ) {
if ( isHidden ) {
return null;
}

return <SidebarNavigationItemContent { ...props } />;
}

function SidebarNavigationItemContent( {
className,
icon,
withChevron = false,
Expand Down
105 changes: 49 additions & 56 deletions packages/edit-site/src/components/sidebar-navigation-screen-main/index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,52 +23,46 @@ import SidebarNavigationItem from '../sidebar-navigation-item';
export function MainSidebarNavigationContent( { isBlockBasedTheme = true } ) {
return (
<ItemGroup className="edit-site-sidebar-navigation-screen-main">
{ isBlockBasedTheme && (
<>
<SidebarNavigationItem
to="/identity"
uid="identity-navigation-item"
icon={ siteLogo }
activeOnRouteName="identity"
>
{ _x( 'Identity', 'site identity' ) }
</SidebarNavigationItem>
<SidebarNavigationItem
to="/styles"
uid="global-styles-navigation-item"
icon={ styles }
activeOnRouteName="styles"
>
{ __( 'Styles' ) }
</SidebarNavigationItem>
<SidebarNavigationItem
uid="page-navigation-item"
to="/page"
withChevron
icon={ page }
>
{ __( 'Pages' ) }
</SidebarNavigationItem>
<SidebarNavigationItem
uid="navigation-navigation-item"
to="/navigation"
withChevron
icon={ navigation }
>
{ __( 'Navigation' ) }
</SidebarNavigationItem>
</>
) }
{ ! isBlockBasedTheme && (
<SidebarNavigationItem
uid="stylebook-navigation-item"
to="/stylebook"
withChevron
icon={ styles }
>
{ __( 'Styles' ) }
</SidebarNavigationItem>
) }
<SidebarNavigationItem
to="/identity"
uid="identity-navigation-item"
icon={ siteLogo }
activeOnRouteName="identity"
isHidden={ ! isBlockBasedTheme }
>
{ _x( 'Identity', 'site identity' ) }
</SidebarNavigationItem>
<SidebarNavigationItem
to={ isBlockBasedTheme ? '/styles' : '/stylebook' }
uid={
isBlockBasedTheme
? 'global-styles-navigation-item'
: 'stylebook-navigation-item'
}
icon={ styles }
activeOnRouteName={ isBlockBasedTheme ? 'styles' : undefined }
withChevron={ ! isBlockBasedTheme }
>
{ __( 'Styles' ) }
</SidebarNavigationItem>
<SidebarNavigationItem
uid="page-navigation-item"
to="/page"
withChevron
icon={ page }
isHidden={ ! isBlockBasedTheme }
>
{ __( 'Pages' ) }
</SidebarNavigationItem>
<SidebarNavigationItem
uid="navigation-navigation-item"
to="/navigation"
withChevron
icon={ navigation }
isHidden={ ! isBlockBasedTheme }
>
{ __( 'Navigation' ) }
</SidebarNavigationItem>
<SidebarNavigationItem
uid="patterns-navigation-item"
to="/pattern"
Expand All @@ -77,16 +71,15 @@ export function MainSidebarNavigationContent( { isBlockBasedTheme = true } ) {
>
{ __( 'Patterns' ) }
</SidebarNavigationItem>
{ isBlockBasedTheme && (
<SidebarNavigationItem
uid="template-navigation-item"
to="/template"
withChevron
icon={ layout }
>
{ __( 'Templates' ) }
</SidebarNavigationItem>
) }
<SidebarNavigationItem
uid="template-navigation-item"
to="/template"
withChevron
icon={ layout }
isHidden={ ! isBlockBasedTheme }
>
{ __( 'Templates' ) }
</SidebarNavigationItem>
</ItemGroup>
);
}
Expand Down
Loading