Skip to content

Template Part: Remove restriction on tabs / inspector fills #79181

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
talldan merged 4 commits into from
Jun 16, 2026
Merged

Template Part: Remove restriction on tabs / inspector fills #79181

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
efaab84
Allow template parts showing styles
talldan Jun 15, 2026
a5aafff
Allow style tab to be shown for template parts
talldan Jun 15, 2026
ef83037
Improve comments
talldan Jun 15, 2026
17d0083
Apply suggestions from code review
talldan Jun 16, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion packages/block-editor/src/components/inspector-controls-tabs/styles-tab.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -79,7 +79,11 @@ const StylesTab = ( {
contentClientIds={ contentClientIds }
/>
) }
{ ! isSectionBlock && (
{
// Extenders have in the past always been allowed to add controls to group
// the restrictions are lessened for that block.
}
Comment thread
talldan marked this conversation as resolved.
{ ( ! isSectionBlock || blockName === 'core/template-part' ) && (
<>
<InspectorControls.Slot
group="color"
Expand Down
14 changes: 6 additions & 8 deletions packages/block-editor/src/components/inspector-controls/fill.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,6 @@ import {
import { ListViewContentFill } from './list-view-content-popover';

const PATTERN_EDITING_GROUPS = [ 'content', 'list' ];
const TEMPLATE_PART_GROUPS = [ 'default', 'settings', 'advanced' ];

export default function InspectorControlsFill( {
children,
Expand Down Expand Up @@ -56,17 +55,16 @@ export default function InspectorControlsFill( {

// During pattern editing:
// - All blocks can show pattern editing groups (content, list).
// - Template parts can show a settings tab (default, settings, advanced groups).
// - Template parts can show any inspector group.
// - Other blocks cannot show a settings tab.
if ( context[ mayDisplayPatternEditingControlsKey ] ) {
// Template parts are allowed to show a settings tab to allow access to the
// 'Design' and 'Advanced' panels.
// Template parts have also historically supported
// any block inspector groups for extenders. The settings
// tab is also used by core for the 'Design' panel. Specifically
// for that block the restrictions on allowed groups are lessened.
const isTemplatePart = context.name === 'core/template-part';
const isTemplatePartGroup = TEMPLATE_PART_GROUPS.includes( group );
const isPatternEditingGroup = PATTERN_EDITING_GROUPS.includes( group );

const canShowGroup =
( isTemplatePart && isTemplatePartGroup ) || isPatternEditingGroup;
const canShowGroup = isTemplatePart || isPatternEditingGroup;

if ( ! canShowGroup ) {
return null;
Expand Down
Loading