Skip to content

Format Library: Migrate to recommended @wordpress/ui components #79059

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Mamaduka merged 1 commit into from
Jun 9, 2026
Merged

Format Library: Migrate to recommended @wordpress/ui components #79059

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 8 additions & 9 deletions packages/format-library/src/image/index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,12 +6,10 @@ import {
SVG,
Popover,
Button,
ExternalLink,
__experimentalHStack as HStack,
__experimentalVStack as VStack,
__experimentalNumberControl as NumberControl,
TextareaControl,
} from '@wordpress/components';
import { Link, Stack } from '@wordpress/ui';
import { __ } from '@wordpress/i18n';
import { useState } from '@wordpress/element';
import { insertObject, useAnchor } from '@wordpress/rich-text';
Expand Down Expand Up @@ -100,7 +98,7 @@ function InlineUI( { value, onChange, activeObjectAttributes, contentRef } ) {
event.preventDefault();
} }
>
<VStack spacing={ 4 }>
<Stack direction="column" gap="lg">
<NumberControl
__next40pxDefaultSize
label={ __( 'Width' ) }
Expand All @@ -118,7 +116,8 @@ function InlineUI( { value, onChange, activeObjectAttributes, contentRef } ) {
} }
help={
<>
<ExternalLink
<Link
openInNewTab
href={
// translators: Localized tutorial, if one exists. W3C Web Accessibility Initiative link has list of existing translations.
__(
Expand All @@ -129,13 +128,13 @@ function InlineUI( { value, onChange, activeObjectAttributes, contentRef } ) {
{ __(
'Describe the purpose of the image.'
) }
</ExternalLink>
</Link>
<br />
{ __( 'Leave empty if decorative.' ) }
</>
}
/>
<HStack justify="right">
<Stack justify="right">
<Button
disabled={ ! hasChanged }
accessibleWhenDisabled
Expand All @@ -145,8 +144,8 @@ function InlineUI( { value, onChange, activeObjectAttributes, contentRef } ) {
>
{ __( 'Apply' ) }
</Button>
</HStack>
</VStack>
</Stack>
</Stack>
</form>
</Popover>
);
Expand Down
16 changes: 8 additions & 8 deletions packages/format-library/src/language/index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,9 +12,8 @@ import {
SelectControl,
Button,
Popover,
__experimentalHStack as HStack,
__experimentalVStack as VStack,
} from '@wordpress/components';
import { Stack } from '@wordpress/ui';
import { useState } from '@wordpress/element';
import { applyFormat, removeFormat, useAnchor } from '@wordpress/rich-text';
import { language as languageIcon } from '@wordpress/icons';
Expand Down Expand Up @@ -83,9 +82,10 @@ function InlineLanguageUI( { value, contentRef, onChange, onClose } ) {
anchor={ popoverAnchor }
onClose={ onClose }
>
<VStack
as="form"
spacing={ 4 }
<Stack
render={ <form /> }
direction="column"
gap="lg"
className="block-editor-format-toolbar__language-container-content"
onSubmit={ ( event ) => {
event.preventDefault();
Expand Down Expand Up @@ -126,15 +126,15 @@ function InlineLanguageUI( { value, contentRef, onChange, onClose } ) {
] }
onChange={ ( val ) => setDir( val ) }
/>
<HStack alignment="right">
<Stack justify="right">
<Button
__next40pxDefaultSize
variant="primary"
type="submit"
text={ __( 'Apply' ) }
/>
</HStack>
</VStack>
</Stack>
</Stack>
</Popover>
);
}
7 changes: 3 additions & 4 deletions packages/format-library/src/link/css-classes-setting.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,9 +7,8 @@ import { __ } from '@wordpress/i18n';
import {
__experimentalInputControl as InputControl,
CheckboxControl,
__experimentalVStack as VStack,
} from '@wordpress/components';
import { VisuallyHidden } from '@wordpress/ui';
import { Stack, VisuallyHidden } from '@wordpress/ui';

/**
* CSSClassesSettingComponent
Expand Down Expand Up @@ -58,7 +57,7 @@ const CSSClassesSettingComponent = ( { setting, value, onChange } ) => {
<VisuallyHidden render={ <legend /> }>
{ setting.title }
</VisuallyHidden>
<VStack spacing={ 3 }>
<Stack direction="column" gap="md">
<CheckboxControl
label={ setting.title }
onChange={ handleCheckboxChange }
Expand All @@ -82,7 +81,7 @@ const CSSClassesSettingComponent = ( { setting, value, onChange } ) => {
/>
</div>
) }
</VStack>
</Stack>
</fieldset>
);
};
Expand Down
6 changes: 3 additions & 3 deletions packages/format-library/src/math/index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,9 +8,9 @@ import { RichTextToolbarButton } from '@wordpress/block-editor';
import {
Popover,
TextControl,
__experimentalVStack as VStack,
privateApis as componentsPrivateApis,
} from '@wordpress/components';
import { Stack } from '@wordpress/ui';
import { math as icon } from '@wordpress/icons';
import { speak } from '@wordpress/a11y';

Expand Down Expand Up @@ -88,7 +88,7 @@ function InlineUI( {
className="block-editor-format-toolbar__math-popover"
>
<div style={ { minWidth: '300px', padding: '4px' } }>
<VStack spacing={ 1 }>
<Stack direction="column" gap="xs">
<TextControl
__next40pxDefaultSize
hideLabelFromVision
Expand All @@ -114,7 +114,7 @@ function InlineUI( {
<style children=".wp-block-math__error .components-badge__content{white-space:normal}" />
</>
) }
</VStack>
</Stack>
</div>
</Popover>
);
Expand Down
27 changes: 11 additions & 16 deletions packages/format-library/src/text-color/inline.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,19 +16,14 @@ import {
getColorObjectByAttributeValues,
store as blockEditorStore,
} from '@wordpress/block-editor';
import {
Popover,
privateApis as componentsPrivateApis,
} from '@wordpress/components';
import { Popover } from '@wordpress/components';
import { Tabs } from '@wordpress/ui';
import { __ } from '@wordpress/i18n';

/**
* Internal dependencies
*/
import { textColor as settings, transparentValue } from './index';
import { unlock } from '../lock-unlock';

const { Tabs } = unlock( componentsPrivateApis );

const TABS = [
{ name: 'color', title: __( 'Text' ) },
Expand Down Expand Up @@ -168,18 +163,18 @@ export default function InlineColorUI( {
className="format-library__inline-color-popover"
anchor={ popoverAnchor }
>
<Tabs>
<Tabs.TabList>
<Tabs.Root defaultValue={ TABS[ 0 ].name }>
<Tabs.List>
{ TABS.map( ( tab ) => (
<Tabs.Tab tabId={ tab.name } key={ tab.name }>
<Tabs.Tab value={ tab.name } key={ tab.name }>
{ tab.title }
</Tabs.Tab>
) ) }
</Tabs.TabList>
</Tabs.List>
{ TABS.map( ( tab ) => (
<Tabs.TabPanel
tabId={ tab.name }
focusable={ false }
<Tabs.Panel
value={ tab.name }
tabIndex={ -1 }
key={ tab.name }
>
<ColorPicker
Expand All @@ -188,9 +183,9 @@ export default function InlineColorUI( {
value={ value }
onChange={ onChange }
/>
</Tabs.TabPanel>
</Tabs.Panel>
) ) }
</Tabs>
</Tabs.Root>
</Popover>
);
}
17 changes: 0 additions & 17 deletions tools/eslint/suppressions.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1265,43 +1265,26 @@
}
},
"packages/format-library/src/image/index.js": {
"@wordpress/use-recommended-components": {
"count": 3
},
"react-hooks/refs": {
"count": 2
}
},
"packages/format-library/src/language/index.js": {
"@wordpress/use-recommended-components": {
"count": 2
},
"react-hooks/refs": {
"count": 2
}
},
"packages/format-library/src/link/css-classes-setting.js": {
"@wordpress/use-recommended-components": {
"count": 1
}
},
"packages/format-library/src/link/inline.js": {
"react-hooks/refs": {
"count": 2
}
},
"packages/format-library/src/math/index.js": {
"@wordpress/use-recommended-components": {
"count": 1
},
"react-hooks/refs": {
"count": 2
}
},
"packages/format-library/src/text-color/inline.js": {
"@wordpress/use-recommended-components": {
"count": 1
},
"react-hooks/refs": {
"count": 2
}
Expand Down
Loading