Skip to content

Release Tools: Drop the root @wordpress/release-tools dependency - #79046

Closed
im3dabasia wants to merge 10 commits into
WordPress:trunkfrom
im3dabasia:feat/ci-workflow-update-75041
Closed

im3dabasia wants to merge 10 commits into
WordPress:trunkfrom
im3dabasia:feat/ci-workflow-update-75041

Conversation

@im3dabasia

@im3dabasia im3dabasia commented Jun 9, 2026 •

Copy link
Copy Markdown
Contributor

What?

Removes @wordpress/release-tools from the root package.json devDependencies. Part of #75041.

Why?

  • The root should declare only what it actually runs.
  • npm links every workspace bin into root node_modules/.bin regardless.
  • validation-tools, build and docgen already sit there with no root entry.

How?

  • Drops the devDependency and its single lockfile line.
  • Every npm exec --no release-cli call site is untouched and still resolves.
  • The workflow changes this PR originally carried are gone. Build/Test Tools: Replace npx with npm exec --no #82331 landed the same goal in a safer form, and npm exec --workspace runs the binary with the working directory set to tools/release — which breaks the relative --repository-path ../publish that release-cli resolves against process.cwd().

Testing Instructions

  • npm install
  • npm exec --no release-cli -- --help still resolves.
  • Static checks and the lockfile lint pass.

@im3dabasia im3dabasia self-assigned this Jun 9, 2026
@im3dabasia
im3dabasia requested a review from manzoorwanijk June 9, 2026 10:46
@im3dabasia im3dabasia added [Type] Enhancement A suggestion for improvement. Gutenberg Plugin Issues or PRs related to Gutenberg Plugin management related efforts labels Jun 9, 2026

@manzoorwanijk manzoorwanijk left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is beneficial if we can remove @wordpress/release-tools and @wordpress/validation-tools from the root package.json.

@manzoorwanijk manzoorwanijk added [Type] Code Quality Issues or PRs that relate to code quality and removed [Type] Enhancement A suggestion for improvement. labels Jun 9, 2026
@im3dabasia
im3dabasia force-pushed the feat/ci-workflow-update-75041 branch from 9a5eeed to 0d1a6b7 Compare June 10, 2026 09:59
Comment thread package.json Outdated
Comment thread package.json
Comment thread package.json

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR continues the workspace migration by removing the root-level @wordpress/release-tools dependency and updating CI/scripts to invoke validation and release tooling via their dedicated npm workspaces.

Changes:

  • Remove @wordpress/release-tools from the root devDependencies.
  • Update static-checks.yml to run lockfile/tsconfig validation via @wordpress/validation-tools workspace scripts.
  • Update publish-npm-packages.yml to execute release publishing commands via the @wordpress/release-tools workspace.

Reviewed changes

Copilot reviewed 3 out of 4 changed files in this pull request and generated 2 comments.

File Description
package.json Removes root dependency on release tools and updates a release-related script to use a workspace-scoped npm exec.
package-lock.json Updates lockfile metadata to reflect removal of the root dependency entry.
.github/workflows/static-checks.yml Runs package-lock and tsconfig validation directly from the validation-tools workspace.
.github/workflows/publish-npm-packages.yml Switches npm publishing steps to execute release tooling from the release-tools workspace.

Comment thread package.json Outdated
Comment thread .github/workflows/publish-npm-packages.yml Outdated

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 3 out of 4 changed files in this pull request and generated 4 comments.

Comment thread package.json Outdated
"lint:php": "wp-env run --env-cwd='wp-content/plugins/gutenberg' cli composer run-script lint",
"lint:pkg-json": "wp-scripts lint-pkg-json . 'packages/*/package.json'",
"other:changelog": "npm exec --no release-cli -- changelog",
"other:changelog": "npm exec --workspace @wordpress/release-tools -- release-cli changelog",
cd cli
npm ci
npm exec --no release-cli -- npm-next --ci --repository-path ../publish
npm exec --workspace @wordpress/release-tools -- release-cli -- npm-next --ci --repository-path ../publish
cd cli
npm ci
npm exec --no release-cli -- npm-latest --semver minor --ci --repository-path ../publish
npm exec --workspace @wordpress/release-tools -- release-cli -- npm-latest --semver minor --ci --repository-path ../publish
cd cli
npm ci
npm exec --no release-cli -- npm-bugfix --ci --repository-path ../publish
npm exec --workspace @wordpress/release-tools -- release-cli -- npm-bugfix --ci --repository-path ../publish
@im3dabasia
im3dabasia marked this pull request as ready for review June 24, 2026 12:20
@im3dabasia
im3dabasia requested a review from desrosj as a code owner June 24, 2026 12:20
@github-actions

Copy link
Copy Markdown

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message.

Co-authored-by: im3dabasia <im3dabasia1@git.wordpress.org>
Co-authored-by: manzoorwanijk <manzoorwanijk@git.wordpress.org>

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

@manzoorwanijk

Copy link
Copy Markdown
Member

Let us update this PR from trunk and also address the feedback from Copilot - #79046 (review)

@im3dabasia

Copy link
Copy Markdown
Contributor Author

Hi @manzoorwanijk,

Sorry for the late response. I noticed that the issue has been marked as completed. I just wanted to check if we should still move forward with this PR.

I’d be happy to make the necessary changes by EOD if they’re still needed. Please let me know when you get a chance. Thanks!

@manzoorwanijk

Copy link
Copy Markdown
Member

This is still a good change to make.

@manzoorwanijk

Copy link
Copy Markdown
Member

Some Copilot comments are related to #82331. So let us wait for #82331 to land and then update this.

@im3dabasia

Copy link
Copy Markdown
Contributor Author

Some Copilot comments are related to #82331. So let us wait for #82331 to land and then update this.

Sure!

Resolved by taking trunk for .github/workflows/static-checks.yml,
.github/workflows/publish-npm-packages.yml and the other:changelog script:
WordPress#82331 already routes those through the workspaces, and the --workspace form
this branch used changes the working directory, which breaks the relative
--repository-path passed to release-cli.

What remains from this branch is dropping @wordpress/release-tools from the
root devDependencies. npm links every workspace bin into the root
node_modules/.bin regardless, so 'npm exec --no release-cli' still resolves.
@im3dabasia im3dabasia changed the title Release Tools: Update YAML CI Workflow to use Work Space Release Tools: Drop the root @wordpress/release-tools dependency Sep 9, 2026
@im3dabasia

Copy link
Copy Markdown
Contributor Author

Hey @manzoorwanijk

A lot changed after #82331 got merged, so this PR has moved quite far from its initial code. There's still one important thing left in it that's worth doing. Could you take a look and let me know whether this can still make it to trunk? Looking forward to your thoughts.

@manzoorwanijk

manzoorwanijk commented Sep 9, 2026 •

Copy link
Copy Markdown
Member

A lot changed after #82331 got merged, so this PR has moved quite far from its initial code. There's still one important thing left in it that's worth doing. Could you take a look and let me know whether this can still make it to trunk? Looking forward to your thoughts.

The PR currently does nothing more than removing @wordpress/release-tools from root deps. 🤔

Will it work in isolated deps mode?

@im3dabasia

Copy link
Copy Markdown
Contributor Author

The PR currently does nothing more than removing @wordpress/release-tools from root deps. 🤔

Unfortunately 😂

Will it work in isolated deps mode?

Good catch, it won't; the root actually uses release-cli, so it's an honest dependency, not a phantom one.

Closing this.

Thanks !

@im3dabasia im3dabasia closed this Sep 9, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Gutenberg Plugin Issues or PRs related to Gutenberg Plugin management related efforts [Type] Code Quality Issues or PRs that relate to code quality

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants