Skip to content

Columns: Remove redundant Skip option from layout picker #78405

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
t-hamano merged 5 commits into from
May 19, 2026
Merged

Columns: Remove redundant Skip option from layout picker #78405

Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
c978977
fix : remove redundant skip option from columns block
dpmehta May 18, 2026
021a840
fix : add relevant test case
dpmehta May 18, 2026
b6e5e86
fix : recover allowSkip from BlockVariationPicker and related styling
dpmehta May 19, 2026
2b4ca8c
add line break
dpmehta May 19, 2026
de9a2dc
fix : remove redundant test case
dpmehta May 19, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 3 additions & 9 deletions packages/block-library/src/columns/edit.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -267,17 +267,12 @@ function ColumnsEditContainer( { attributes, setAttributes, clientId } ) {
}

function Placeholder( { clientId, name, setAttributes } ) {
const { blockType, defaultVariation, variations } = useSelect(
const { blockType, variations } = useSelect(
( select ) => {
const {
getBlockVariations,
getBlockType,
getDefaultBlockVariation,
} = select( blocksStore );
const { getBlockVariations, getBlockType } = select( blocksStore );

return {
blockType: getBlockType( name ),
defaultVariation: getDefaultBlockVariation( name, 'block' ),
variations: getBlockVariations( name, 'block' ),
};
},
Expand All @@ -293,7 +288,7 @@ function Placeholder( { clientId, name, setAttributes } ) {
label={ blockType?.title }
variations={ variations }
instructions={ __( 'Divide into columns. Select a layout:' ) }
onSelect={ ( nextVariation = defaultVariation ) => {
onSelect={ ( nextVariation ) => {
if ( nextVariation.attributes ) {
setAttributes( nextVariation.attributes );
}
Expand All @@ -307,7 +302,6 @@ function Placeholder( { clientId, name, setAttributes } ) {
);
}
} }
allowSkip
/>
</div>
);
Expand Down
Loading