Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

remove test from being skipped (editor/hooks/test/align.js) #7837

Closed
wants to merge 0 commits into from
Closed

remove test from being skipped (editor/hooks/test/align.js) #7837

wants to merge 0 commits into from

Conversation

nerrad
Copy link
Contributor

@nerrad nerrad commented Jul 9, 2018 •
edited
Loading

Description

Ideally we should not be skipping tests as its easy to forget they are skipped. This switches the skipped test to use React.TestRenderer so it can be unskipped.

Checklist:

  • My code is tested.
  • My code follows the WordPress code style.
  • My code follows the accessibility standards.
  • My code has proper inline documentation.

@nerrad nerrad requested review from gziolo and aduth July 9, 2018 18:48
@nerrad nerrad self-assigned this Jul 9, 2018
@nerrad nerrad added [Type] Automated Testing Testing infrastructure changes impacting the execution of end-to-end (E2E) and/or unit tests. [Type] Refactoring labels Jul 9, 2018
@nerrad nerrad changed the title remove test from being skipped (editor/hooks/test/align.js remove test from being skipped (editor/hooks/test/align.js) Jul 9, 2018
gziolo
gziolo approved these changes Jul 9, 2018
View reviewed changes
Copy link
Member

@gziolo gziolo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice one, it turned out to be so easy to fix 😃

@nerrad nerrad closed this Jul 9, 2018
@nerrad nerrad force-pushed the update/remove-tests-from-being-skipped-editor-hooks.align.js branch from e6fc643 to d11bbf8 Compare July 9, 2018 23:44
@nerrad nerrad deleted the update/remove-tests-from-being-skipped-editor-hooks.align.js branch July 9, 2018 23:45
@nerrad
Copy link
Contributor Author

nerrad commented Jul 9, 2018

This was actually fixed in a separate branch (#7752)

@nerrad nerrad mentioned this pull request Jul 18, 2018
Closed
@ellatrix ellatrix added [Type] Code Quality Issues or PRs that relate to code quality and removed [Type] Code Quality Issues or PRs that relate to code quality labels Nov 27, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gziolo gziolo gziolo approved these changes

@aduth aduth Awaiting requested review from aduth

Assignees

@nerrad nerrad

Labels
[Type] Automated Testing Testing infrastructure changes impacting the execution of end-to-end (E2E) and/or unit tests. [Type] Code Quality Issues or PRs that relate to code quality
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@nerrad @gziolo @ellatrix