Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

remove tests from being skipped (components/disabled/test/index.js) #7835

Merged
merged 1 commit into from
Jul 10, 2018
Merged

remove tests from being skipped (components/disabled/test/index.js) #7835

merged 1 commit into from
Jul 10, 2018

Conversation

nerrad
Copy link
Contributor

@nerrad nerrad commented Jul 9, 2018 •
edited
Loading

Description

Ideally we should not be skipping tests. This pull converts the tests for the disabled component to use React.TestUtils and un-skips them.

Checklist:

  • My code is tested.
  • My code follows the WordPress code style.
  • My code follows the accessibility standards.
  • My code has proper inline documentation.

@nerrad nerrad requested review from noisysocks and aduth July 9, 2018 17:16
@nerrad nerrad added [Type] Automated Testing Testing infrastructure changes impacting the execution of end-to-end (E2E) and/or unit tests. [Type] Refactoring labels Jul 9, 2018
@nerrad nerrad self-assigned this Jul 9, 2018
noisysocks
noisysocks approved these changes Jul 10, 2018
View reviewed changes
Copy link
Member

@noisysocks noisysocks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Thanks for fixing this.

@nerrad nerrad merged commit c314b15 into master Jul 10, 2018
@nerrad nerrad deleted the update/remove-tests-from-being-skipped-disabled_test_index.js branch July 10, 2018 00:16
@gziolo gziolo added this to the 3.3 milestone Jul 10, 2018
@gziolo gziolo mentioned this pull request Jul 13, 2018
Closed
@ellatrix ellatrix added [Type] Code Quality Issues or PRs that relate to code quality and removed [Type] Code Quality Issues or PRs that relate to code quality labels Nov 27, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@noisysocks noisysocks noisysocks approved these changes

@aduth aduth Awaiting requested review from aduth

Assignees

@nerrad nerrad

Labels
[Type] Automated Testing Testing infrastructure changes impacting the execution of end-to-end (E2E) and/or unit tests. [Type] Code Quality Issues or PRs that relate to code quality
Projects
None yet
Milestone
3.3
Development

Successfully merging this pull request may close these issues.
4 participants
@nerrad @noisysocks @gziolo @ellatrix