Switch away from using enzyme.mount in tests (viewport/test/with-viewport-match.js) #7828
Conversation
This switches all tests in `viewport/test/with-viewport-match.js` from using enzyme.mount to `React.TestUtils`. This is because `enzyme` does not fully support React 16.3+ (and movement to do so is really slow). This will fix issues with breakage due to the enzyme incompatibility as components receive React 16.3+ features (such as `forwardRef` usage in #7557).
nerrad
added
[Type] Automated Testing
|
|
||
| expect( wrapper.find( Component ).props() ).toEqual( { isWide: true } ); | ||
| expect( wrapper.root.findByType( ChildComponent ).props.isWide ) |
There was a problem hiding this comment.
It isn't exactly the same check. Can we update it to make sure it doesn't change anything?
There was a problem hiding this comment.
I'm sorry I'm not sure exactly what you mean by "Can we update it to make sure it doesn't change anything?". I'm also not sure why you think this isn't the same check. I had to wrap ChildComponent in the TestComponent so effectively I'm doing the same test, just doing a different method for getting the component to test. This same method will apply when HOCs are returning a forwardRef wrapped component (in 7557).
There was a problem hiding this comment.
Another alternative here would be to use TestUtils to do a full mount into the DOM and then traverse actual HTMLElement nodes to verify expected results? But I'm not sure that is any better than what is happening here?
There was a problem hiding this comment.
expect( wrapper.root.findByType( ChildComponent ).props ).toEqual( { isWide: true });This is what I thought about. Does ref causes any issues here?
There was a problem hiding this comment.
I ensured these tests passed against 7557 (while preserving the intent of the test). Then ensured the same tests passed against master (if they didn't pass against master then I knew there was a problem).
gziolo
deleted the
update/with-viewport-match.js-replace-usage-of-enzyme.mount-with-React.TestRenderer
branch
ellatrix
added
[Type] Code Quality
Description
This switches all tests in
viewport/test/with-viewport-match.jsfrom using enzyme.mount toReact.TestUtils. This is becauseenzymedoes not fully support React 16.3+ (and movement to do so is really slow). This will fix issues with breakage due to the enzyme incompatibility as components receive React 16.3+ features (such asforwardRefusage in #7557).Checklist: