Repository navigation
Button: Align compound component metadata #78184
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
+20
−14
Merged
Changes from 4 commits
Commits
Show all changes
6 commits
Select commit
Hold shift + click to select a range
582e912
Button: Add Icon display name
mirka e67ad43
Move display name to index
mirka 0302030
Button: Move Icon props type
mirka 4781833
Duplicate description
mirka a86635c
Use dot notation in subcomponent tabs
mirka 8d6d2bb
Simplify component description
mirka File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,16 +1,16 @@ | ||
| import { Button as ButtonButton } from './button'; | ||
| import { Button as _Button } from './button'; | ||
| import { ButtonIcon } from './icon'; | ||
|
|
||
| ButtonIcon.displayName = 'Button.Icon'; | ||
|
|
||
| /** | ||
| * A versatile button component with multiple variants, tones, and sizes. | ||
| * Built on design tokens for consistent theming and accessibility. | ||
| */ | ||
| export const Button = Object.assign( ButtonButton, { | ||
| export const Button = Object.assign( _Button, { | ||
| /** | ||
| * An icon component specifically designed to work well when rendered inside | ||
| * a `Button` component. | ||
| */ | ||
| Icon: ButtonIcon, | ||
| } ) as typeof ButtonButton & { | ||
| Icon: typeof ButtonIcon; | ||
| }; | ||
|
Comment on lines
-14
to
-16
Member
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Apparently this cast was only needed because the |
||
| } ); | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.