Skip to content

Experiment: Content types - use form for quick edit dialogs #78149

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ntsekouras merged 1 commit into from
May 11, 2026
Merged

Experiment: Content types - use form for quick edit dialogs #78149

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 9 additions & 4 deletions packages/content-types/src/post-types/actions/quick-edit.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -103,7 +103,12 @@ function QuickEditPostTypeModal( {
}

return (
<>
<form
onSubmit={ ( event ) => {
event.preventDefault();
onSave();
} }
>
<Stack
className="dataviews-action-modal__quick-edit-post-type-header"
direction="row"
Expand Down Expand Up @@ -149,15 +154,15 @@ function QuickEditPostTypeModal( {
<Button
__next40pxDefaultSize
variant="primary"
type="submit"
isBusy={ isSaving }
disabled={ isSaving }
disabled={ isSaving || ! isValid }
accessibleWhenDisabled
onClick={ onSave }
>
{ __( 'Done' ) }
</Button>
</Stack>
</>
</form>
);
}

Expand Down
13 changes: 9 additions & 4 deletions packages/content-types/src/taxonomies/actions/quick-edit.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -101,7 +101,12 @@ function QuickEditTaxonomyModal( {
}

return (
<>
<form
onSubmit={ ( event ) => {
event.preventDefault();
onSave();
} }
>
<Stack
className="dataviews-action-modal__quick-edit-taxonomy-header"
direction="row"
Expand Down Expand Up @@ -147,15 +152,15 @@ function QuickEditTaxonomyModal( {
<Button
__next40pxDefaultSize
variant="primary"
type="submit"
isBusy={ isSaving }
disabled={ isSaving }
disabled={ isSaving || ! isValid }
accessibleWhenDisabled
onClick={ onSave }
>
{ __( 'Done' ) }
</Button>
</Stack>
</>
</form>
);
}

Expand Down
Loading