Skip to content

Image block: Try syncing updated metadata fields (alt and caption) from the media editor #78139

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
andrewserong merged 8 commits into from
May 12, 2026
Merged

Image block: Try syncing updated metadata fields (alt and caption) from the media editor #78139

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
7684fc6
Image block: Try syncing updated metadata fields (alt and caption) fr…
andrewserong May 11, 2026
8f8c683
Try to fix caption sync issue
andrewserong May 11, 2026
12b4d5f
Image block: Refine media editor metadata sync
andrewserong May 11, 2026
f26edc5
Fix edge case when the image block's caption field is empty on page load
andrewserong May 12, 2026
4c21c8a
Add some comments explaining what we're doing
andrewserong May 12, 2026
c076011
Add test to cover empty richtext case
andrewserong May 12, 2026
018182f
Simplify the tests
andrewserong May 12, 2026
ccc8ac8
Consolidate into a single setAttributes call
andrewserong May 12, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
40 changes: 11 additions & 29 deletions packages/block-library/src/image/image.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -62,6 +62,7 @@ import { isExternalImage } from './edit';
import { Caption } from '../utils/caption';
import { MediaControl } from '../utils/media-control';
import { useToolsPanelDropdownMenuProps } from '../utils/hooks';
import { useOpenImageMediaEditorModal } from './use-open-image-media-editor-modal';
import {
MIN_SIZE,
ALLOWED_MEDIA_TYPES,
Expand All @@ -70,12 +71,9 @@ import {
} from './constants';
import { evalAspectRatio, mediaPosition } from './utils';

const {
DimensionsTool,
ResolutionTool,
mediaEditKey,
openMediaEditorModalKey,
} = unlock( blockEditorPrivateApis );
const { DimensionsTool, ResolutionTool, mediaEditKey } = unlock(
blockEditorPrivateApis
);

const scaleOptions = [
{
Expand Down Expand Up @@ -381,20 +379,10 @@ export default function Image( {
[ clientId ]
);
const { getBlock, getSettings } = useSelect( blockEditorStore );
const settings = getSettings();
const openMediaEditorModal = settings[ openMediaEditorModalKey ];

const handleMediaUpdate = useCallback(
Comment on lines -384 to -387

@ramonjd ramonjd May 12, 2026

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍🏻 Makes sense to move this into the new hook

( { id: newId, url: newUrl } ) => {
if ( typeof newId === 'number' && newId !== id ) {
setAttributes( {
id: newId,
url: newUrl ?? url,
} );
}
},
[ id, url, setAttributes ]
);
const openImageMediaEditorModal = useOpenImageMediaEditorModal( {
attributes,
setAttributes,
} );

const {
replaceBlocks,
Expand Down Expand Up @@ -858,18 +846,12 @@ export default function Image( {
{ allowCrop && (
<ToolbarButton
onClick={
openMediaEditorModal && id
? () =>
openMediaEditorModal( {
id,
onUpdate: handleMediaUpdate,
} )
openImageMediaEditorModal
? openImageMediaEditorModal
: () => setIsEditingImage( true )
}
aria-haspopup={
openMediaEditorModal && id
? 'dialog'
: undefined
openImageMediaEditorModal ? 'dialog' : undefined
}
icon={ crop }
label={ __( 'Crop' ) }
Expand Down
Loading
Loading