Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion docs/reference-guides/data/data-core-editor.md
Original file line number Diff line number Diff line change
Expand Up @@ -347,7 +347,7 @@ _Returns_
### getEditedPostSlug
Returns the slug for the post being edited, preferring a manually edited value if one exists, then a sanitized version of the current post title, and finally the post ID.
Returns the slug for the post being edited, preferring a manually edited value if one exists, then the server-generated slug from the post entity, then a JS approximation of the current post title, and finally the post ID.
_Parameters_
Expand Down
5 changes: 3 additions & 2 deletions packages/editor/src/store/selectors.js
Original file line number Diff line number Diff line change
Expand Up @@ -988,8 +988,8 @@ export function getPermalink( state ) {

/**
* Returns the slug for the post being edited, preferring a manually edited
* value if one exists, then a sanitized version of the current post title, and
* finally the post ID.
* value if one exists, then the server-generated slug from the post entity,
* then a JS approximation of the current post title, and finally the post ID.
*
* @param {Object} state Editor state.
*
Expand All @@ -998,6 +998,7 @@ export function getPermalink( state ) {
export function getEditedPostSlug( state ) {
return (
getEditedPostAttribute( state, 'slug' ) ||
getEditedPostAttribute( state, 'generated_slug' ) ||
cleanForSlug( getEditedPostAttribute( state, 'title' ) ) ||
getCurrentPostId( state )
);
Expand Down
40 changes: 39 additions & 1 deletion packages/editor/src/store/test/selectors.jsdom.test.jsx
Original file line number Diff line number Diff line change
Expand Up @@ -2692,7 +2692,45 @@ describe( 'selectors', () => {
expect( getEditedPostSlug( state ) ).toBe( 'edited-slug' );
} );

it( 'should return the cleaned title as slug if no saved or edited slug exists', () => {
it( 'should return the server-generated slug if no saved or edited slug exists', () => {
const state = {
currentPost: {
title: 'Sample Post',
generated_slug: 'server-generated-slug',
},
editor: {
present: {
edits: {},
},
},
};

expect( getEditedPostSlug( state ) ).toBe(
'server-generated-slug'
);
} );

it( 'should prefer the server-generated slug over the cleaned title', () => {
const state = {
currentPost: {
title: 'Sample Post',
generated_slug: 'server-generated-slug',
},
editor: {
present: {
edits: {
title: 'Edited Title',
},
},
},
};

expect( getEditedPostSlug( state ) ).toBe(
'server-generated-slug'
);
} );

it( 'should return the cleaned title as slug if no saved, edited, or generated slug exists', () => {
const state = {
currentPost: {
title: 'Sample Post',
Expand Down
5 changes: 4 additions & 1 deletion packages/fields/src/fields/slug/utils.ts
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,9 @@ export const getSlug = ( item: BasePost ): string => {
}

return (
item.slug || cleanForSlug( getItemTitle( item ) ) || item.id.toString()
item.slug ||
item.generated_slug ||
cleanForSlug( getItemTitle( item ) ) ||
item.id.toString()
);
};
1 change: 1 addition & 0 deletions packages/fields/src/types.ts
Original file line number Diff line number Diff line change
Expand Up @@ -51,6 +51,7 @@ export interface BasePost extends CommonPost {
ping_status?: 'open' | 'closed';
link?: string;
slug?: string;
generated_slug?: string;
sticky?: boolean;
permalink_template?: string;
date?: string;
Expand Down
Loading