Skip to content

Embed: Tighten raw URL transform isMatch #78021

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Mamaduka merged 2 commits into from
May 7, 2026
Merged

Embed: Tighten raw URL transform isMatch #78021

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
186c56c
Embed: Tighten raw URL transform isMatch
Mamaduka May 6, 2026
c8f45a6
Allow common page extensions
Mamaduka May 7, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
21 changes: 17 additions & 4 deletions packages/block-library/src/embed/transforms.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,7 @@
* WordPress dependencies
*/
import { createBlock } from '@wordpress/blocks';
import { isURL, getFilename } from '@wordpress/url';

/**
* Internal dependencies
Expand All @@ -22,10 +23,22 @@ const transforms = {
from: [
{
type: 'raw',
isMatch: ( node ) =>
node.nodeName === 'P' &&
/^\s*(https?:\/\/\S+)\s*$/i.test( node.textContent ) &&
node.textContent?.match( /https/gi )?.length === 1,
isMatch: ( node ) => {
if ( node.nodeName !== 'P' ) {
return false;
}
const trimmed = node.textContent.trim();
if (
! isURL( trimmed ) ||
! /^https:\/\//i.test( trimmed ) ||
trimmed.match( /https:\/\//gi )?.length !== 1
) {
return false;
}
// Reject URLs whose pathname ends in a file extension.
// Embed providers don't use such URLs
return ! /\.[a-z0-9]+$/i.test( getFilename( trimmed ) );
Comment thread
Mamaduka marked this conversation as resolved.
Resolved
},
transform: ( node ) => {
const url = rewriteXToTwitter( node.textContent.trim() );
return createBlock( EMBED_BLOCK, {
Expand Down
Loading