Skip to content

RTC: Attach sync observers after hydrating persisted CRDT doc #77966

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
maxschmeling merged 2 commits into from
May 6, 2026
Merged

RTC: Attach sync observers after hydrating persisted CRDT doc #77966

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
e5aba6b
RTC: Attach sync observers after hydrating persisted CRDT doc
ellatrix May 5, 2026
9fa0f4a
Merge branch 'trunk' into rtc-attach-observers-after-hydration
maxschmeling May 6, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 8 additions & 4 deletions packages/sync/src/manager.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -286,15 +286,19 @@ export function createSyncManager( debug = false ): SyncManager {
} )
);

// Attach observers.
recordMap.observeDeep( onRecordUpdate );
stateMap.observe( onStateMapUpdate );

// Initialize the Yjs document with the necessary CRDT state.
initializeYjsDoc( ydoc );

// Get and apply the persisted CRDT document, if it exists.
// Observers are attached after hydration so the applyUpdateV2 inside
// _applyPersistedCrdtDoc does not trigger _updateEntityRecord with the
// just-loaded state, which would dispatch a redundant editRecord whose
// blocks already match the editor's parsed content.
internal.applyPersistedCrdtDoc( objectType, objectId, record );

// Attach observers.
recordMap.observeDeep( onRecordUpdate );
stateMap.observe( onStateMapUpdate );
}

/**
Expand Down
Loading