Switch test away from using enzyme.mount (editor/components/url-input/test/button.js)
#7786
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This switched the `should close the form when user submits it` from using enzyme.mount to React.TestUtilities. This is because enzyme does not fully support React 16.3+ (and movement to do so is really slow). This will fix issues with breakage due to the enzyme incompatibility as components receive React 16.3+ features (such as forwardRef usage in #7557). This specific test was the only one to fail in #7557 due to the test involving the EnhancedAutocomplete component that has forwardRef applied on it.
nerrad
added
the
[Type] Automated Testing
gziolo
approved these changes
Jul 12, 2018
| TestUtils.Simulate.submit( formElement() ); | ||
| expect( wrapper.state.expanded ).toBe( false ); | ||
| /* eslint-disable react/no-find-dom-node */ | ||
| ReactDOM.unmountComponentAtNode( ReactDOM.findDOMNode( wrapper ).parentNode ); |
There was a problem hiding this comment.
This should happen in afterEach section to make sure it is executed also when the test fails.
However, I'm planning on introducing some helpers to take care of it behind the scenes. We can get back to it later.
gziolo
deleted the
update/replace-usage-of-enzyme.mount-with-React.TestUtils-button.js
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This switched the
should close the form when user submits ittest ineditor/components/url-input/test/button.jsfrom using enzyme.mount toReact.TestUtilities. This is becauseenzymedoes not fully support React 16.3+ (and movement to do so is really slow). This will fix issues with breakage due to the enzyme incompatibility as components receive React 16.3+ features (such asforwardRefusage in #7557).Checklist: