Skip to content

Fix: Buttons block shows inserter picker when multiple allowed blocks are registered #77858

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Mamaduka merged 2 commits into from
May 6, 2026
Merged

Fix: Buttons block shows inserter picker when multiple allowed blocks are registered #77858

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
b43e869
Fix: Buttons block shows inserter picker when multiple allowed blocks…
adithya-naik Apr 30, 2026
ad4d838
Simplify: Remove directInsert logic as Inserter now handles it intern…
adithya-naik May 5, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 0 additions & 13 deletions packages/block-library/src/buttons/edit.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,8 +7,6 @@ import clsx from 'clsx';
* WordPress dependencies
*/
import { useBlockProps, useInnerBlocksProps } from '@wordpress/block-editor';
import { useSelect } from '@wordpress/data';
import { store as blocksStore } from '@wordpress/blocks';

const DEFAULT_BLOCK = {
name: 'core/button',
Expand All @@ -32,20 +30,9 @@ function ButtonsEdit( { attributes, className } ) {
'has-custom-font-size': fontSize || style?.typography?.fontSize,
} ),
} );
const { hasButtonVariations } = useSelect( ( select ) => {
const buttonVariations = select( blocksStore ).getBlockVariations(
'core/button',
'inserter'
);
return {
hasButtonVariations: buttonVariations.length > 0,
};
}, [] );

const innerBlocksProps = useInnerBlocksProps( blockProps, {
defaultBlock: DEFAULT_BLOCK,
// This check should be handled by the `Inserter` internally to be consistent across all blocks that use it.
directInsert: ! hasButtonVariations,
template: [ [ 'core/button' ] ],
templateInsertUpdatesSelection: true,
orientation: layout?.orientation ?? 'horizontal',
Expand Down
Loading