Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Convert tests using enzyme to use react-test-renderer instead (components/inserter/test/menu.js) #7773

Merged
merged 4 commits into from
Jul 13, 2018
Merged

Convert tests using enzyme to use react-test-renderer instead (components/inserter/test/menu.js) #7773

merged 4 commits into from
Jul 13, 2018

Commits on Jul 11, 2018

  1. convert enzyme usage to react-test-renderer usage.

    @nerrad
    nerrad committed Jul 11, 2018
    Configuration menu
    Copy the full SHA
    c5381dd View commit details
    Browse the repository at this point in the history

  2. account for possibility of class name string being in different order

    @nerrad
    nerrad committed Jul 11, 2018
    Configuration menu
    Copy the full SHA
    557b4bb View commit details
    Browse the repository at this point in the history

  3. update tests to use TestUtils 

    This allows for more accurately testing rendered expectations.
    @nerrad
    nerrad committed Jul 11, 2018
    Configuration menu
    Copy the full SHA
    85810b8 View commit details
    Browse the repository at this point in the history

Commits on Jul 13, 2018

  1. fixes from review 

    - use SCREAMING_SNAKECASE for constant (standards)
- refactor unnecessary module scoped variable
    @nerrad
    nerrad committed Jul 13, 2018
    Configuration menu
    Copy the full SHA
    aa7eb2b View commit details
    Browse the repository at this point in the history