Skip to content

e2e: shorten visit-site-editor canvas-loader visible wait #77725

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ramonjd merged 1 commit into from
Apr 28, 2026
Merged

e2e: shorten visit-site-editor canvas-loader visible wait #77725

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 6 additions & 2 deletions packages/e2e-test-utils-playwright/src/admin/visit-site-editor.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -67,8 +67,12 @@ export async function visitSiteEditor(

try {
// Wait for the canvas loader to appear first, so that the locator that
// waits for the hidden state doesn't resolve prematurely.
await canvasLoader.waitFor( { state: 'visible', timeout: 60_000 } );
// waits for the hidden state doesn't resolve prematurely. The loader
// either renders within a tick or it is skipped entirely (when the
// editor finishes resolving inside the artificial-delay window in
// `useIsSiteEditorLoading`), so a long visible-state timeout is just
// wasted wall clock when the loader never shows up.
await canvasLoader.waitFor( { state: 'visible', timeout: 3_000 } );
await canvasLoader.waitFor( {
state: 'hidden',
// Bigger timeout is needed for larger entities, like the Large Post
Expand Down
Loading