Skip to content

Migrate pattern list item titles to Text from @wordpress/ui #77656

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mirka merged 7 commits into from
May 14, 2026
+7 −4
Merged

Migrate pattern list item titles to Text from @wordpress/ui #77656

Changes from 4 commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
5122efe
refactor: migrate title to use Text component from @wordpress/ui
kushagra-goyal-14 Apr 24, 2026
e423cd0
Merge branch 'trunk' into refactor/migrate-experimantal-text-to-block…
kushagra-goyal-14 Apr 30, 2026
f55ee04
fix: add div to the render tag as Text uses span by default
kushagra-goyal-14 Apr 30, 2026
c7b91cb
Merge branch 'trunk' into refactor/migrate-experimantal-text-to-block…
kushagra-goyal-14 May 2, 2026
3c65611
Merge branch 'trunk' into refactor/migrate-experimantal-text-to-block…
kushagra-goyal-14 May 7, 2026
53b183c
fix: update BlockPattern title rendering and adjust styles
kushagra-goyal-14 May 7, 2026
69e85e0
Merge branch 'trunk' into refactor/migrate-experimantal-text-to-block…
kushagra-goyal-14 May 7, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 6 additions & 3 deletions packages/block-editor/src/components/block-patterns-list/index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@ import {
Tooltip,
__experimentalHStack as HStack,
} from '@wordpress/components';
import { VisuallyHidden } from '@wordpress/ui';
import { VisuallyHidden, Text } from '@wordpress/ui';
import { useInstanceId } from '@wordpress/compose';
import { __ } from '@wordpress/i18n';
import { Icon, symbol } from '@wordpress/icons';
Expand Down Expand Up @@ -154,9 +154,12 @@ function BlockPattern( {
/>
</div>
) }
<div className="block-editor-block-patterns-list__item-title">
<Text
render={ <div /> }
className="block-editor-block-patterns-list__item-title"

@mirka mirka May 4, 2026

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this an ad hoc override, or a redundant font size style, or is the Text variant wrong?

gutenberg/packages/block-editor/src/components/block-patterns-list/style.scss

Line 36 in e6c1d49

font-size: $helptext-font-size;

@kushagra-goyal-14 kushagra-goyal-14 May 7, 2026

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for catching that @mirka . I checked both variants:

body-sm: 12px font-size, 16px line-height, removes CSS override entirely.

body-md: would require keeping the CSS override, with 20px line-height.

Since the original font styling was effectively 12px and the original height of the div was 18.2px, I am leaning towards body-sm for a clean look. Please share your thoughts if that works.

@mirka mirka May 7, 2026

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, that makes sense.

@kushagra-goyal-14 kushagra-goyal-14 May 7, 2026

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, made the changes.

>
{ pattern.title }
</div>
</Text>
</HStack>
) }

Expand Down
Loading