Skip to content

Embed: Fix variation upgrade undo trap #77546

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Mamaduka merged 8 commits into from
Apr 23, 2026
Merged

Embed: Fix variation upgrade undo trap #77546

Show file tree
Hide file tree
Changes from 5 commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
90cf139
Combine two URL effects
Mamaduka Apr 21, 2026
951b552
Fix undo trap
Mamaduka Apr 21, 2026
97fd448
Add failing e2e test for remaining bug
Mamaduka Apr 22, 2026
a164edc
Align logic in native files
Mamaduka Apr 22, 2026
2946e6d
Remove e2e test for different PR
Mamaduka Apr 22, 2026
3e964a1
Mark URL rewriting attribute updates and non-persistent
Mamaduka Apr 23, 2026
55758ec
Improve URL rewriting logic
Mamaduka Apr 23, 2026
ba67196
Handle X url rewrite during submission
Mamaduka Apr 23, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
130 changes: 71 additions & 59 deletions packages/block-library/src/embed/edit.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,8 +1,29 @@
/**
* External dependencies
*/
import clsx from 'clsx';

/**
* WordPress dependencies
*/
import { __, _x, sprintf } from '@wordpress/i18n';
import { useState, useEffect } from '@wordpress/element';
import { useDispatch, useSelect } from '@wordpress/data';
import {
useBlockProps,
store as blockEditorStore,
} from '@wordpress/block-editor';
import { store as coreStore } from '@wordpress/core-data';
import { View } from '@wordpress/primitives';
import { getAuthority } from '@wordpress/url';
import { Caption } from '../utils/caption';

/**
* Internal dependencies
*/
import {
createUpgradedEmbedBlock,
findMoreSuitableBlock,
getClassNames,
removeAspectRatioClasses,
fallback,
Expand All @@ -15,23 +36,6 @@ import EmbedLoading from './embed-loading';
import EmbedPlaceholder from './embed-placeholder';
import EmbedPreview from './embed-preview';

/**
* External dependencies
*/
import clsx from 'clsx';

/**
* WordPress dependencies
*/
import { __, _x, sprintf } from '@wordpress/i18n';
import { useState, useEffect } from '@wordpress/element';
import { useDispatch, useSelect } from '@wordpress/data';
import { useBlockProps } from '@wordpress/block-editor';
import { store as coreStore } from '@wordpress/core-data';
import { View } from '@wordpress/primitives';
import { getAuthority } from '@wordpress/url';
import { Caption } from '../utils/caption';

const EmbedEdit = ( props ) => {
const {
attributes: {
Expand All @@ -58,6 +62,8 @@ const EmbedEdit = ( props ) => {
const [ url, setURL ] = useState( attributesUrl );
const [ isEditingURL, setIsEditingURL ] = useState( false );
const { invalidateResolution } = useDispatch( coreStore );
const { __unstableMarkNextChangeAsNotPersistent } =
useDispatch( blockEditorStore );

const {
preview,
Expand Down Expand Up @@ -131,63 +137,65 @@ const EmbedEdit = ( props ) => {
} );
}

// When the preview can't be embedded, try rewriting the URL and resubmit.
useEffect( () => {
if ( preview?.html || ! cannotEmbed || ! hasResolved ) {
if ( ! cannotEmbed || ! hasResolved || ! attributesUrl ) {
return;
}

// Until X provider is supported in WordPress, as a workaround we use Twitter provider.
if ( getAuthority( attributesUrl ) === 'x.com' ) {
const newURL = new URL( attributesUrl );
newURL.host = 'twitter.com';
const newURLString = newURL.toString();
Comment thread
Mamaduka marked this conversation as resolved.
Resolved
setAttributes( {
url: newURLString,
...findMoreSuitableBlock( newURLString )?.attributes,
} );
return;
}

// At this stage, we're not fetching the preview and know it can't be embedded,
// so try removing any trailing slash, and resubmit.
// Otherwise, try removing any trailing slash.
const newURL = attributesUrl.replace( /\/$/, '' );
setURL( newURL );
setIsEditingURL( false );
setAttributes( { url: newURL } );
}, [
preview?.html,
attributesUrl,
cannotEmbed,
hasResolved,
setAttributes,
] );
if ( newURL !== attributesUrl ) {
setURL( newURL );
setAttributes( { url: newURL } );
setIsEditingURL( false );
}
}, [ attributesUrl, cannotEmbed, hasResolved, setAttributes ] );

// Try a different provider in case the embed url is not supported.
// Apply preview-derived attributes once the preview resolves.
useEffect( () => {
if ( ! cannotEmbed || fetching || ! url ) {
if ( ! preview || isEditingURL ) {
return;
}

// Until X provider is supported in WordPress, as a workaround we use Twitter provider.
if ( getAuthority( url ) === 'x.com' ) {
const newURL = new URL( url );
newURL.host = 'twitter.com';
setAttributes( { url: newURL.toString() } );
}
}, [ url, cannotEmbed, fetching, setAttributes ] );
const mergedAttributes = getMergedAttributes();

// Handle incoming preview.
useEffect( () => {
if ( preview && ! isEditingURL ) {
// When obtaining an incoming preview,
// we set the attributes derived from the preview data.
const mergedAttributes = getMergedAttributes();
const hasChanges = Object.keys( mergedAttributes ).some(
( key ) => mergedAttributes[ key ] !== attributes[ key ]
if ( onReplace ) {
const upgradedBlock = createUpgradedEmbedBlock(
props,
mergedAttributes
);

if ( hasChanges ) {
setAttributes( mergedAttributes );
if ( upgradedBlock ) {
// Mutate via setAttributes; onReplace would remount the
// block and clear the URL textbox on undo.
__unstableMarkNextChangeAsNotPersistent();
setAttributes( upgradedBlock.attributes );
return;
}
}

if ( onReplace ) {
const upgradedBlock = createUpgradedEmbedBlock(
props,
mergedAttributes
);
const hasChanges = Object.keys( mergedAttributes ).some(
( key ) => mergedAttributes[ key ] !== attributes[ key ]
);

if ( upgradedBlock ) {
onReplace( upgradedBlock );
}
}
if ( hasChanges ) {
// Merge into the URL-submit undo level so a single undo
// reverts both the submit and the preview-driven attributes.
__unstableMarkNextChangeAsNotPersistent();
setAttributes( mergedAttributes );
}
}, [ preview, isEditingURL ] );

Expand Down Expand Up @@ -225,8 +233,12 @@ const EmbedEdit = ( props ) => {
attributes.className
);

setAttributes( {
url,
...findMoreSuitableBlock( url )?.attributes,
className: blockClass,
} );
setIsEditingURL( false );
setAttributes( { url, className: blockClass } );
} }
value={ url }
cannotEmbed={ cannotEmbed }
Expand Down
126 changes: 72 additions & 54 deletions packages/block-library/src/embed/edit.native.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,21 +1,3 @@
/**
* Internal dependencies
*/
import {
createUpgradedEmbedBlock,
getClassNames,
removeAspectRatioClasses,
fallback,
getEmbedInfoByProvider,
getMergedAttributesWithPreview,
} from './util';
import EmbedControls from './embed-controls';
import { embedContentIcon } from './icons';
import EmbedLoading from './embed-loading';
import EmbedPlaceholder from './embed-placeholder';
import EmbedPreview from './embed-preview';
import EmbedLinkSettings from './embed-link-settings';

/**
* External dependencies
*/
Expand All @@ -35,6 +17,25 @@ import { store as coreStore } from '@wordpress/core-data';
import { View } from '@wordpress/primitives';
import { getAuthority } from '@wordpress/url';

/**
* Internal dependencies
*/
import {
createUpgradedEmbedBlock,
findMoreSuitableBlock,
getClassNames,
removeAspectRatioClasses,
fallback,
getEmbedInfoByProvider,
getMergedAttributesWithPreview,
} from './util';
import EmbedControls from './embed-controls';
import { embedContentIcon } from './icons';
import EmbedLoading from './embed-loading';
import EmbedPlaceholder from './embed-placeholder';
import EmbedPreview from './embed-preview';
import EmbedLinkSettings from './embed-link-settings';

// The inline preview feature will be released progressible, for this reason
// the embed will only be considered previewable for the following providers list.
const PREVIEWABLE_PROVIDERS = [ 'youtube', 'twitter', 'instagram', 'vimeo' ];
Expand Down Expand Up @@ -77,6 +78,8 @@ const EmbedEdit = ( props ) => {
const [ showEmbedBottomSheet, setShowEmbedBottomSheet ] =
useState( isEditingURL );
const { invalidateResolution } = useDispatch( coreStore );
const { __unstableMarkNextChangeAsNotPersistent } =
useDispatch( blockEditorStore );

const { preview, fetching, themeSupportsResponsive, cannotEmbed } =
useSelect(
Expand Down Expand Up @@ -150,18 +153,7 @@ const EmbedEdit = ( props ) => {
} );
};

useEffect( () => {
if ( ! preview?.html || ! cannotEmbed || fetching ) {
return;
}
// At this stage, we're not fetching the preview and know it can't be embedded,
// so try removing any trailing slash, and resubmit.
const newURL = url.replace( /\/$/, '' );
setIsEditingURL( false );
setAttributes( { url: newURL } );
}, [ preview?.html, url, cannotEmbed, fetching ] );

// Try a different provider in case the embed url is not supported.
// When the preview can't be embedded, try rewriting the URL and resubmit.
useEffect( () => {
if ( ! cannotEmbed || fetching || ! url ) {
return;
Expand All @@ -171,29 +163,55 @@ const EmbedEdit = ( props ) => {
if ( getAuthority( url ) === 'x.com' ) {
const newURL = new URL( url );
newURL.host = 'twitter.com';
setAttributes( { url: newURL.toString() } );
const newURLString = newURL.toString();
setAttributes( {
url: newURLString,
...findMoreSuitableBlock( newURLString )?.attributes,
} );
return;
}

// Otherwise, try removing any trailing slash.
const newURL = url.replace( /\/$/, '' );
if ( newURL !== url ) {
setIsEditingURL( false );
setAttributes( { url: newURL } );
}
}, [ url, cannotEmbed, fetching, setAttributes ] );

// Handle incoming preview.
// Apply preview-derived attributes once the preview resolves.
useEffect( () => {
if ( preview && ! isEditingURL ) {
// When obtaining an incoming preview,
// we set the attributes derived from the preview data.
const mergedAttributes = getMergedAttributes();
setAttributes( mergedAttributes );
if ( ! preview || isEditingURL ) {
return;
}

if ( onReplace ) {
const upgradedBlock = createUpgradedEmbedBlock(
props,
mergedAttributes
);
const mergedAttributes = getMergedAttributes();

if ( upgradedBlock ) {
onReplace( upgradedBlock );
}
if ( onReplace ) {
const upgradedBlock = createUpgradedEmbedBlock(
props,
mergedAttributes
);

if ( upgradedBlock ) {
// Mutate via setAttributes; onReplace would remount the
// block and clear the URL textbox on undo.
__unstableMarkNextChangeAsNotPersistent();
setAttributes( upgradedBlock.attributes );
return;
}
}

const hasChanges = Object.keys( mergedAttributes ).some(
( key ) => mergedAttributes[ key ] !== attributes[ key ]
);

if ( hasChanges ) {
// Merge into the URL-submit undo level so a single undo
// reverts both the submit and the preview-driven attributes.
__unstableMarkNextChangeAsNotPersistent();
setAttributes( mergedAttributes );
}
}, [ preview, isEditingURL ] );

useEffect(
Expand All @@ -203,19 +221,19 @@ const EmbedEdit = ( props ) => {

const onEditURL = useCallback(
( value ) => {
// If the embed URL was changed, we need to reset the aspect ratio class.
// To do this we have to remove the existing ratio class so it can be recalculated.
if ( attributes.url !== value ) {
const blockClass = removeAspectRatioClasses(
attributes.className
);
setAttributes( { className: blockClass } );
}
const urlChanged = attributes.url !== value;

// The order of the following calls is important, we need to update the URL attribute before changing `isEditingURL`,
// otherwise the side-effect that potentially replaces the block when updating the local state won't use the new URL
// for creating the new block.
setAttributes( { url: value } );
setAttributes( {
url: value,
...findMoreSuitableBlock( value )?.attributes,
// If the embed URL was changed, reset the aspect ratio class so it can be recalculated.
...( urlChanged && {
className: removeAspectRatioClasses( attributes.className ),
} ),
} );
setIsEditingURL( false );
},
[ attributes, setAttributes ]
Expand Down
6 changes: 4 additions & 2 deletions packages/block-library/src/embed/transforms.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@ import { createBlock } from '@wordpress/blocks';
* Internal dependencies
*/
import metadata from './block.json';
import { removeAspectRatioClasses } from './util';
import { findMoreSuitableBlock, removeAspectRatioClasses } from './util';

const { name: EMBED_BLOCK } = metadata;

Expand All @@ -23,8 +23,10 @@ const transforms = {
/^\s*(https?:\/\/\S+)\s*$/i.test( node.textContent ) &&
node.textContent?.match( /https/gi )?.length === 1,
transform: ( node ) => {
const url = node.textContent.trim();
return createBlock( EMBED_BLOCK, {
url: node.textContent.trim(),
url,
...findMoreSuitableBlock( url )?.attributes,
} );
},
},
Expand Down
Loading
Loading