Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions packages/dependency-extraction-webpack-plugin/lib/util.js
Original file line number Diff line number Diff line change
Expand Up @@ -41,6 +41,7 @@ function defaultRequestToExternal( request ) {
return 'React';

case 'react-dom':
case 'react-dom/client':
return 'ReactDOM';

case 'react/jsx-runtime':
Expand Down Expand Up @@ -123,6 +124,9 @@ function defaultRequestToHandle( request ) {
case 'lodash-es':
return 'lodash';

case 'react-dom/client':
return 'react-dom';

case 'react/jsx-runtime':
return 'react-jsx-runtime';
}
Expand Down
28 changes: 28 additions & 0 deletions packages/dependency-extraction-webpack-plugin/test/util.js
Original file line number Diff line number Diff line change
Expand Up @@ -47,6 +47,20 @@ describe( 'defaultRequestToExternal', () => {
defaultRequestToExternal( '@wordpress/some-future-package' )
).toEqual( [ 'wp', 'someFuturePackage' ] );
} );

test( 'Handles react request', () => {
expect( defaultRequestToExternal( 'react' ) ).toBe( 'React' );
} );

test( 'Handles react-dom request', () => {
expect( defaultRequestToExternal( 'react-dom' ) ).toBe( 'ReactDOM' );
} );

test( 'Handles react-dom/client request', () => {
expect( defaultRequestToExternal( 'react-dom/client' ) ).toBe(
'ReactDOM'
);
} );
} );

describe( 'defaultRequestToHandle', () => {
Expand All @@ -63,4 +77,18 @@ describe( 'defaultRequestToHandle', () => {
defaultRequestToHandle( '@wordpress/some-future-package' )
).toBe( 'wp-some-future-package' );
} );

test( 'Handles react request', () => {
expect( defaultRequestToHandle( 'react' ) ).toBeUndefined();
} );

test( 'Handles react-dom request', () => {
expect( defaultRequestToHandle( 'react-dom' ) ).toBeUndefined();
} );

test( 'Handles react-dom/client request', () => {
expect( defaultRequestToHandle( 'react-dom/client' ) ).toBe(
'react-dom'
);
} );
} );
4 changes: 4 additions & 0 deletions packages/wp-build/lib/wordpress-externals-plugin.mjs
Original file line number Diff line number Diff line change
Expand Up @@ -125,6 +125,10 @@ export function createWordpressExternalsPlugin(
const vendorExternals = {
react: { global: 'React', handle: 'react' },
'react-dom': { global: 'ReactDOM', handle: 'react-dom' },
'react-dom/client': {
global: 'ReactDOM',
handle: 'react-dom',
},
'react/jsx-runtime': {
global: 'ReactJSXRuntime',
handle: 'react-jsx-runtime',
Expand Down
Loading