Skip to content

Fix: Only auto register settings if the plugin the connector references is installed and active. #77273

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
t-hamano merged 3 commits into from
May 7, 2026
Merged

Fix: Only auto register settings if the plugin the connector references is installed and active. #77273

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
2cefca3
Connectors: Gate non-AI default setting auto-registration
jorgefilipecosta Apr 13, 2026
be86d42
Connectors: Unify default setting auto-registration gate
jorgefilipecosta May 4, 2026
ec62104
Merge branch 'trunk' into codex/connectors-auto-registration-gate
t-hamano May 7, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions backport-changelog/7.0/11564.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
https://github.com/WordPress/wordpress-develop/pull/11564
10 changes: 6 additions & 4 deletions lib/experimental/connectors/default-connectors.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -373,10 +373,9 @@ function _gutenberg_connectors_rest_settings_dispatch( WP_REST_Response $respons
* @access private
*/
function _gutenberg_register_default_connector_settings(): void {
$ai_registry = \WordPress\AiClient\AiClient::defaultRegistry();
$existing_settings = get_registered_settings();

foreach ( wp_get_connectors() as $connector_id => $connector_data ) {
foreach ( wp_get_connectors() as $connector_data ) {
$auth = $connector_data['authentication'];
if ( 'api_key' !== $auth['method'] || empty( $auth['setting_name'] ) ) {
continue;
Expand All @@ -387,8 +386,11 @@ function _gutenberg_register_default_connector_settings(): void {
continue;
}

// For AI providers, skip if the provider is not in the AI Client registry.
if ( 'ai_provider' === $connector_data['type'] && ! $ai_registry->hasProvider( $connector_id ) ) {
if ( ! isset( $connector_data['plugin']['is_active'] ) || ! is_callable( $connector_data['plugin']['is_active'] ) ) {
continue;
}

if ( ! call_user_func( $connector_data['plugin']['is_active'] ) ) {
continue;
}

Expand Down
Loading