Skip to content

FormTokenField: fix disabled styles #77137

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
oandregal merged 5 commits into from
Apr 9, 2026
Merged

FormTokenField: fix disabled styles #77137

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
4e87d8c
FormTokenField: fix disabled styles
oandregal Apr 8, 2026
4afd897
Add changelog entry
oandregal Apr 8, 2026
17c2e2a
Apply suggestion from @Copilot
oandregal Apr 9, 2026
e2e7257
Apply suggestion from @Copilot
oandregal Apr 9, 2026
53d9bc2
Merge branch 'trunk' into fix/disabled-styles-form-token
oandregal Apr 9, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions packages/components/CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,7 @@

### Bug Fixes

- `FormTokenField`: Fix disabled styles. [#77137](https://github.com/WordPress/gutenberg/pull/77137)
- `Textarea`: Fix disabled styles [#77129](https://github.com/WordPress/gutenberg/pull/77129).
- `Autocomplete`: Fix value comparison to avoid resetting block inserter in RTC ([#76980](https://github.com/WordPress/gutenberg/pull/76980)).
- `ValidatedRangeControl`: Fix `aria-label` rendered as `[object Object]` when `required` or `markWhenOptional` is set ([#77042](https://github.com/WordPress/gutenberg/pull/77042)).
Expand Down
14 changes: 12 additions & 2 deletions packages/components/src/form-token-field/style.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,8 +11,10 @@
cursor: text;

&.is-disabled {
background: $gray-300;
border-color: $gray-300;
background: $components-color-gray-100;
border-color: $components-color-gray-400;
cursor: default;
opacity: 1;
Comment on lines +16 to +17

@ciampo ciampo Apr 10, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why where the cursor and opacity rules needed?

@oandregal oandregal Apr 13, 2026

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Adding opacity was a misunderstanding. I'm removing it #77263

The cursor is to prevent it from switching to text if users cannot interact with the control.

@oandregal oandregal Apr 13, 2026

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I appreciate the post-merge review, btw.

}

&.is-active {
Expand Down Expand Up @@ -82,6 +84,14 @@
}
}

&.is-disabled {
.components-form-token-field__token-text,
.components-form-token-field__remove-token.components-button {
background: $components-color-gray-100;
color: $components-color-gray-600;
}
}

&.is-borderless {
position: relative;
padding: 0 24px 0 0;
Expand Down
Loading