Repository navigation
Conversation
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
t-hamano
added
[Type] Bug
Mamaduka
reviewed
Apr 2, 2026
Mamaduka
left a comment
Mamaduka
left a comment
Member
There was a problem hiding this comment.
While I like the attempts, this makes labels less predictable. A user will still see the Type / ... label before selecting a block, and then it will change to something else.
I don't think this is a better behavior.
| const { getBlockRootClientId, getInserterItems } = | ||
| select( blockEditorStore ); | ||
| const rootClientId = getBlockRootClientId( clientId ); | ||
| const items = getInserterItems( rootClientId ); |
Member
There was a problem hiding this comment.
This is an expensive selector. Blocks shouldn't call it.
Contributor
Author
The hook runs for empty blocks as well as selected ones, so this should not occur. However, on initial page render, the placeholder changes... cd6cf2165b0f1dbb7182e75837259b69.mp4 |
|
Size Change: +162 B (0%) Total Size: 7.74 MB
ℹ️ View Unchanged
|
Member
|
Oh, sorry missed that condition. Still feels "ricky" and we're introducing a lot of complexity just to change strings. I don't have any bright ideas at the moment, but there should be a better way. |
Contributor
Author
|
Closing this in favor of #77052. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What?
Alternatives to #76988
Why?
How?
Testing Instructions
Testing Instructions for Keyboard
Screenshots or screencast
Use of AI Tools