Repository navigation
Add emoji reactions (limited set on notes) #76767
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
adamsilverstein
wants to merge
197
commits into
trunk
from
add-notes-emoji-reactions-try-addditional-comment-type
+3,783
−1
Open
Changes from all commits
Commits
Show all changes
197 commits
Select commit
Hold shift + click to select a range
5198d77
Add ReactionEmojiPicker component for Notes
adamsilverstein ae75200
Add ReactionDisplay component for Notes
adamsilverstein c1e5de3
Add ReactionDetailsPopover component for Notes
adamsilverstein 3634a3a
Add reaction CRUD functions to useBlockCommentsActions
adamsilverstein bfc2251
Add styles for emoji reactions in Notes
adamsilverstein 07fdd9d
Fix emoji reaction button: use smiley icon, fix focus, and improve st…
adamsilverstein bcdd7b1
Move emoji reaction button to header and register _wp_reactions meta
adamsilverstein 0dfecd1
Fix emoji reaction pills dark background
adamsilverstein deadca6
Override Button is-pressed style on reaction pills
adamsilverstein e9a7e8e
Make reaction pill buttons more circular
adamsilverstein fb6cf20
update docblock
adamsilverstein a70fdb0
Refactor to use 'Composite' component
Mamaduka 3863dc4
Move _wp_reactions meta to wordpress-7.0 compat
adamsilverstein e2e7e0e
Remove unnecessary login checks from reaction handlers
adamsilverstein ebbea88
Remove reflowComments from reaction handlers
adamsilverstein 6bbf119
Batch user fetching in reaction details popover
adamsilverstein c74ebcb
Update reaction button icon per design feedback
adamsilverstein 5cc8faa
Replace thumbs down reaction with thinking emoji
adamsilverstein 6d43109
Linter and styling fixes
adamsilverstein fc7c864
Store emoji slugs in database instead of emoji characters
adamsilverstein 1eb8484
Use Button component in emoji picker / simplify CSS
adamsilverstein e79c876
finish switch to button and emoji as slugs
adamsilverstein fb0a432
Make emoji reaction picker vertical
adamsilverstein 8972f77
Reduce emoji reactions to five skin-tone-safe options
adamsilverstein d412d82
more style cleanup
adamsilverstein 84859e7
Use Button component in emoji picker to reduce CSS
adamsilverstein 52fc351
Rename _wp_reactions meta key to _wp_note_reactions
adamsilverstein 6e3b0a7
Apply suggestion from @t-hamano
adamsilverstein a9d5814
Move currentUserId selector into ReactionDisplay
adamsilverstein 7806966
Replace reaction details popover with tooltips
adamsilverstein beb23b0
Consolidate reaction functions into onToggleReaction
adamsilverstein 53e9acb
Move reaction button to comment content area
adamsilverstein 3250491
Add missing primitives reference to editor tsconfig
adamsilverstein 76831a6
Fix CI: update package-lock.json and E2E emoji reaction tests
adamsilverstein d003523
Close emoji picker popover after selecting a reaction
adamsilverstein 191f882
Update packages/editor/src/components/collab-sidebar/style.scss
adamsilverstein 946b98c
Add backport changelog entry for core PR 10930
adamsilverstein 19ddc47
move backport changelog to 7.0
adamsilverstein 8e473b4
Switch emoji reactions to custom comment type
adamsilverstein 5e8d355
Add backport changelog entry for PR 75549
adamsilverstein 11e2e18
Show add-reaction button on touch devices
adamsilverstein e63ff96
Show add-reaction button only on hover on desktop
adamsilverstein 8b7920f
Make reaction emoji list filterable via settings
adamsilverstein 74be8ac
Add note_reaction_emojis filter for emoji list
adamsilverstein e27a6f5
Move add-reaction button to reactions row
adamsilverstein 4617545
Simplify reaction placement and style from Mamaduka
adamsilverstein ad62218
Revert filterable emoji list for note reactions
adamsilverstein bc92992
Rename note_reaction comment type to reaction
adamsilverstein 66968d0
Move reaction PHP code to lib/compat/wordpress-7.1
adamsilverstein e1aa343
Expose allowed reaction emojis via REST API schema
adamsilverstein b5acc0e
Fix CI: add new PR to backport changelog and fix PHP alignment
adamsilverstein 224a4b6
Fix children link type for notes, unmount safety, and stale closure
adamsilverstein f910344
Fix schema tests to call get_item_schema() directly
adamsilverstein 13fd4d8
Fix prettier formatting in reaction-emoji-picker
adamsilverstein 5be22c8
Add reaction_summary field to note REST responses
adamsilverstein 0845744
Use reaction_summary from REST API instead of fetching all reactions
adamsilverstein 92c0326
Add PHP tests for reaction_summary field
adamsilverstein 1ec7941
Fix PHP alignment warnings
adamsilverstein b410b5a
Fix PHP alignment in test file
adamsilverstein eb587d7
Move smiley icon to @wordpress/icons package
adamsilverstein 543dfe7
Lazy-load user names for reaction tooltips on hover
adamsilverstein ea4905a
Replace GROUP_CONCAT with separate user query for reaction summaries
adamsilverstein b1a7618
Notes: Document rationale for storing reactions as a custom comment type
adamsilverstein 4f45d7d
Notes: Update reaction E2E tests to renamed fixture and method
adamsilverstein 0f0f812
Notes: Use --wpds-cursor-control token on add-reaction button
adamsilverstein 4f782d2
Notes: Centralize internal comment types via gutenberg_get_internal_c…
adamsilverstein d000a4d
Notes: Add Frimousse-based full emoji picker behind a + button
adamsilverstein d9f1ac8
Notes: Bundle Frimousse emoji data, normalize reaction storage
adamsilverstein 1124da2
Notes: Move full picker to a sibling button + add E2E tests
adamsilverstein e9e43ea
Notes: Serve emojibase data from plugins_url, drop bundle inflation
adamsilverstein c120aac
Notes: Replace Menu.Popover with Dropdown so reaction popovers escape…
adamsilverstein ab18eaa
Notes: Add E2E tests pinning the popover-portal and selection-persist…
adamsilverstein 8576647
Notes: Wrap Frimousse popover tightly to its picker
adamsilverstein 6021c5a
Notes: Size Frimousse picker to its 8-column grid, not an arbitrary s…
adamsilverstein 459d7c6
Notes: Allow re-adding a reaction after removing it on the same note
adamsilverstein 45be10c
Notes: Drop empty wordpress-7.0/block-comments.php compat shim
adamsilverstein fe23e2a
Notes: Force-delete reactions and refetch only the toggled note's record
adamsilverstein ac175cc
Notes: Replace Frimousse picker with native SearchControl + Composite…
adamsilverstein f0038b9
Notes: Move full emoji picker to a follow-up PR
adamsilverstein e02e83e
Notes: Drop hex-key storage helpers and orphan picker CSS
adamsilverstein 0734bf1
Notes: Consolidate reaction failure-case tests with a data provider
adamsilverstein 26a6739
Notes: Switch curated reaction picker from vertical to horizontal
adamsilverstein 49cc701
Update backport-changelog/7.0/10930.md
adamsilverstein bafb480
Update packages/editor/src/components/collab-sidebar/style.scss
adamsilverstein 0a3e814
Notes: Standardize add-reaction button to 24px height
adamsilverstein e25ad38
Notes: Disable add-reaction button on resolved threads
adamsilverstein e89d3f5
Notes: Switch emoji slug lookups to a memoized Map
adamsilverstein 38229af
Notes: Inline smiley icon, drop from public @wordpress/icons
adamsilverstein 7b497a6
Notes: Harden note and reaction creation permissions
adamsilverstein a21001b
Notes: Stop overriding note children link with reactions
adamsilverstein 8182634
Notes: Drop OPTIONS emoji fetch in favor of curated client list
adamsilverstein 405c556
Notes: Extend the core comment controller instead of the removed 6.9 …
adamsilverstein e85f85c
Notes: Use user-facing role selectors for reaction-button e2e assertions
adamsilverstein 95f250d
Build: Drop the stray 'Step 7.5' comment from build.mjs
adamsilverstein 773292d
Notes: Restrict reaction read access to author and editors
adamsilverstein 5890c09
Notes: Exclude reactions from the comment-count query per internal type
adamsilverstein c52939b
Notes: Canonicalize stored reaction slug and reject invalid codepoints
adamsilverstein 0c02b3f
Notes: Invalidate reaction tooltip cache when adding via the picker
adamsilverstein 95d3586
Notes: Harden reaction tests against leaked filters and snackbar timing
adamsilverstein 8809f28
Notes: Converge concurrent duplicate reactions to a single row
adamsilverstein 531bcf4
Notes: Re-select the note thread before removing a reaction in e2e
adamsilverstein 735dd6a
Merge branch 'trunk' into add-notes-emoji-reactions-try-addditional-c…
adamsilverstein 04ff952
Notes: Add unit tests for reaction display and emoji picker
adamsilverstein 0ecba04
Notes: Add test that notes and reactions stay out of comment counts
adamsilverstein 0b58a36
Merge remote-tracking branch 'origin/add-notes-emoji-reactions-try-ad…
adamsilverstein 0c65a93
Add translator context to reaction emoji labels
adamsilverstein e3b3a5d
Merge branch 'trunk' into add-notes-emoji-reactions-try-addditional-c…
adamsilverstein b7f88e6
Merge branch 'trunk' into add-notes-emoji-reactions-try-addditional-c…
adamsilverstein 786eebb
Merge remote-tracking branch 'origin/trunk' into add-notes-emoji-reac…
adamsilverstein d05c91d
Notes reactions: use standard Button styles for triggers and pills
adamsilverstein 5e19a13
Notes reactions: use accent tint for the reacted pill state
adamsilverstein 3dd4f26
Merge remote-tracking branch 'origin/trunk' into add-notes-emoji-reac…
adamsilverstein 6179be8
Remove reaction added/removed snackbars
adamsilverstein 3af9768
Convert new reaction modules to TypeScript
adamsilverstein 05c6c6b
Wire the reaction emoji filter to the picker and cover it with e2e
adamsilverstein 36d7796
Merge remote-tracking branch 'origin/trunk' into add-notes-emoji-reac…
adamsilverstein a8779a7
Merge remote-tracking branch 'origin/trunk' into add-notes-emoji-reac…
adamsilverstein 6bc2fec
Merge trunk into add-notes-emoji-reactions-try-addditional-comment-type
adamsilverstein a52e9f9
Merge trunk into add-notes-emoji-reactions-try-addditional-comment-type
adamsilverstein 57d5348
Merge remote-tracking branch 'origin/trunk' into add-notes-emoji-reac…
adamsilverstein 8f87eca
Notes: Fix reaction picker layout and arrow-key navigation
adamsilverstein a5b27f2
Merge remote-tracking branch 'origin/trunk' into add-notes-emoji-reac…
adamsilverstein 7d66848
Merge remote-tracking branch 'origin/trunk' into add-notes-emoji-reac…
adamsilverstein bb8206e
Drop stale dependency-group comments and hoist a stray import
adamsilverstein 73e59d3
Merge trunk into add-notes-emoji-reactions-try-addditional-comment-type
adamsilverstein 011b99b
Adapt reaction tests to trunk's typechecked dev projects
adamsilverstein f1f9816
Editor: reference primitives from the build tsconfig project
adamsilverstein 9e3aff6
Restrict reaction writes to create and delete
adamsilverstein fae6d45
Remove a note's reactions when the note goes
adamsilverstein 9ef52cf
Present the reaction picker as a group of buttons
adamsilverstein c1ddeb7
Lock reactions on a resolved note thread
adamsilverstein 193fed6
Page through reactions before naming reactors
adamsilverstein fcb732e
Keep reaction state consistent when the refetch fails
adamsilverstein 1e051ca
Fix the concurrent-cleanup regression test setup
adamsilverstein d8018c7
Drive the resolved-reaction test through the sidebar
adamsilverstein 1d1681b
Merge remote-tracking branch 'origin/trunk' into add-notes-emoji-reac…
adamsilverstein 1bd63da
Notes reactions: quiet the reaction pills
adamsilverstein fddf20e
Notes reactions: give the pills room and quiet the trigger at rest
adamsilverstein 821d62f
Notes reactions: build the pills from Design System buttons
adamsilverstein f3a6248
Match the reaction tooltip by its text
adamsilverstein 73d812b
Drop 'emoji' from the reaction tooltip assertion
adamsilverstein 8daff84
Merge remote-tracking branch 'origin/trunk' into add-notes-emoji-reac…
adamsilverstein 85042b8
Align reaction row height and outline unpressed pills
adamsilverstein 7e3a89c
Keep the add-reaction trigger at button height when pills wrap
adamsilverstein 12b68c2
Merge remote-tracking branch 'origin/trunk' into add-notes-emoji-reac…
adamsilverstein 6208740
Rename reaction tests to the jsdom test naming convention
adamsilverstein 6d0c29b
Merge remote-tracking branch 'origin/trunk' into add-notes-emoji-reac…
adamsilverstein 5b98514
Move note reaction compat code to the WordPress 7.2 directory
adamsilverstein 4b59106
Add editor changelog entry for note emoji reactions
adamsilverstein 62a9f07
Merge remote-tracking branch 'origin/trunk' into add-notes-emoji-reac…
adamsilverstein 10f51f9
Tests: Run the reaction tests under Vitest
adamsilverstein 1948472
Tests: Type the api-fetch module mock
adamsilverstein b0cfa57
Merge remote-tracking branch 'origin/trunk' into add-notes-emoji-reac…
adamsilverstein 05b2615
Merge remote-tracking branch 'origin/trunk' into add-notes-emoji-reac…
adamsilverstein e8c4f13
Merge remote-tracking branch 'origin/trunk' into add-notes-emoji-reac…
adamsilverstein 7f143b6
Notes: Use the reaction icon from @wordpress/icons
adamsilverstein 4d22b2d
Notes: Reveal the add-reaction trigger on hover
adamsilverstein 98ab3b0
Notes: Prefetch reaction summaries from the real result set
adamsilverstein 2622bee
Notes: Keep a note's edit-context fields when refreshing reactions
adamsilverstein 16369f1
Merge remote-tracking branch 'origin/trunk' into add-notes-emoji-reac…
adamsilverstein 133b993
Notes: Keep the add-reaction trigger visible once a note has reactions
adamsilverstein 823cda5
Merge trunk into add-notes-emoji-reactions-try-addditional-comment-type
adamsilverstein 42523a9
Merge remote-tracking branch 'origin/trunk' into add-notes-emoji-reac…
adamsilverstein 149ceb0
Notes: Drop the reaction emoji filter for the first iteration
adamsilverstein 1d1bc88
Notes: Skip the reply composer in reaction hover e2e tests
adamsilverstein 39191a4
Notes: Keep reaction emoji in color under forced colors
adamsilverstein ed2d8b7
Notes: Bring reaction PHP in line with the full-picker branch
adamsilverstein bafcb46
Notes: Move reactions into a subdirectory with a useReaction hook
adamsilverstein 19b306c
Notes: Prune emoji reaction e2e tests
adamsilverstein d4dd700
Merge remote-tracking branch 'origin/trunk' into add-notes-emoji-reac…
adamsilverstein c0df5e3
Notes: Enforce reaction ownership and resolved threads on the server
adamsilverstein a6b8e41
Notes: Let forced colors repaint reaction emoji
adamsilverstein 9d7274c
Notes: Stop the thread root walk on a cyclic parent chain
adamsilverstein 0eecd1a
Notes: Guard reaction toggles against stale and repeated clicks
adamsilverstein de57891
Update packages/editor/src/components/collab-sidebar/reactions/add-re…
adamsilverstein fb14fb0
Update packages/editor/src/components/collab-sidebar/reactions/reacti…
adamsilverstein 1731706
Update packages/editor/src/components/collab-sidebar/style.scss
adamsilverstein c604f74
Merge remote-tracking branch 'origin/trunk' into add-notes-emoji-reac…
adamsilverstein ecde935
Notes: Inline the internal comment types instead of a helper
adamsilverstein ea44ad7
Update packages/editor/src/components/collab-sidebar/reactions/reacti…
adamsilverstein 3493442
Notes: Mark own reactions in the picker and hide it on resolved threads
adamsilverstein f195a32
Notes: Localize the reaction pill count
adamsilverstein 0794719
Merge remote-tracking branch 'origin/add-notes-emoji-reactions-try-ad…
adamsilverstein 8755004
Notes: Check a reaction's post before its note's status
adamsilverstein 7fb0577
Merge remote-tracking branch 'origin/trunk' into add-notes-emoji-reac…
adamsilverstein 868802a
Notes: Match the core reaction REST checks from the wpd #10930 backport
adamsilverstein 7704444
Notes: Exclude reactions from comment queries the way core does
adamsilverstein b922830
Notes: Simplify reactions data flow and components
Mamaduka 4062423
Notes: Load reactor names through core-data on hover
Mamaduka 18eff22
Minor cleanup
Mamaduka 42d5115
Merge trunk into add-notes-emoji-reactions-try-addditional-comment-type
adamsilverstein f6eeb0b
Update packages/editor/src/components/collab-sidebar/reactions/reacti…
adamsilverstein ae52d25
Mark where the reaction comment controller diverges from core
adamsilverstein 211fc04
Use block comment style for multi-line reaction comments
adamsilverstein 2d86c80
Tighten types and SQL in the reaction comment controller
adamsilverstein 5ca83ea
Simplify reaction exclusion SQL and type hook callbacks
adamsilverstein cbd8996
Apply batched suggestions from code review
adamsilverstein File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,3 @@ | ||
| https://github.com/WordPress/wordpress-develop/pull/10930 | ||
|
|
||
| * https://github.com/WordPress/gutenberg/pull/76767 | ||
|
adamsilverstein marked this conversation as resolved.
|
||
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.