Repository navigation
Fix locked content when switching to a different template without exiting 'Edit pattern' #76710
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is it possible that the
editedContentOnlySectionis not in the top-level tree, but in a nested one? For example, in a template-locked mode the top-level tree is the post template, then there is a nested controlled entity, like post content or template part, and only in that nested entity is something nested even further, e.g., a pattern?In such a case the
RESET_BLOCKS'action.blockwon't contain the nested block ID. and the flag will be incorrectly cleared.RESET_BLOCKSdoesn't happen only on navigation, but also when the edited entity has changes coming from external source, like from RTC server. ThenuseBlockSyncwill callRESET_BLOCKSwith updated blocks coming from the edited entity.The
blockEditingModesstate has similar problems--what to reset and when?--and I'm trying to figure it out in #76529. That's why this PR caught my attention.Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think that is a possibility. The replace/remove blocks cases could also be more robust and I was planning a follow-up for that.
My idea is to lift the
withInnerBlocksRemoveCascadehigher order reducer up so that other reducers can also access theREPLACE_BLOCKS_AUGMENTED_WITH_CHILDRENandREMOVE_BLOCKS_AUGMENTED_WITH_CHILDRENactions. There are a few reducers across the block editor store that I think probably don't clean up clientId state properly and could benefit.Perhaps something similar is possible with
RESET_BLOCKS.