Skip to content

Fix: Fit text toggle disappears when turned off #76699

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
saranshsinhaa wants to merge 1 commit into from
Closed

Fix: Fit text toggle disappears when turned off #76699

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 5 additions & 5 deletions packages/block-editor/src/hooks/fit-text.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -243,7 +243,7 @@ function useFitText( { fitText, name, clientId } ) {
*/
export function FitTextControl( {
clientId,
fitText = false,
fitText,
setAttributes,
name,
fontSize,
Expand All @@ -256,17 +256,17 @@ export function FitTextControl( {
return (
<InspectorControls group="typography">
<ToolsPanelItem
hasValue={ () => fitText }
hasValue={ () => fitText === true || fitText === false }
label={ __( 'Fit text' ) }
onDeselect={ () => setAttributes( { fitText: undefined } ) }
resetAllFilter={ () => ( { fitText: undefined } ) }
panelId={ clientId }
>
<ToggleControl
label={ __( 'Fit text' ) }
checked={ fitText }
checked={ fitText === true }
onChange={ () => {
const newFitText = ! fitText || undefined;
const newFitText = fitText ? false : true;
const updates = { fitText: newFitText };

// When enabling fit text, clear font size if it has a value
Expand All @@ -288,7 +288,7 @@ export function FitTextControl( {
setAttributes( updates );
} }
help={
fitText
fitText === true
? __( 'Text will resize to fit its container.' )
: __(
'The text will resize to fit its container, resetting other font size settings.'
Expand Down
Loading