Skip to content

Hide Additional CSS controls when block is inside contentOnly editing mode #76512

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
t-hamano merged 9 commits into from
Mar 20, 2026
Merged

Hide Additional CSS controls when block is inside contentOnly editing mode #76512

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
a2090be
Hide Additional CSS controls when block is inside template preview (c…
Shekhar0109 Mar 15, 2026
be2b5fd
Use block editing mode to hide Additional CSS controls in contentOnly…
Shekhar0109 Mar 17, 2026
adc4e0b
Restore AdvancedControls panel and move editing mode check to CustomC…
Shekhar0109 Mar 17, 2026
a18d4de
Revert unnecessary change
t-hamano Mar 18, 2026
2af53a0
Merge branch 'trunk' into fix/76429-hide-advanced-controls
t-hamano Mar 18, 2026
a1b90ff
Fix: restrict Custom CSS control hiding to contentOnly editing mode
Shekhar0109 Mar 18, 2026
12b2bda
Update packages/block-editor/src/hooks/custom-css.js
Shekhar0109 Mar 18, 2026
edb8944
Fix navigation editor E2E test: Settings tab should be hidden when Cu…
Shekhar0109 Mar 19, 2026
3140270
Remove outdated comment and update Settings tab expectation in naviga…
Shekhar0109 Mar 19, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions packages/block-editor/src/hooks/custom-css.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,7 @@ import { useInstanceId } from '@wordpress/compose';
import { getBlockType, hasBlockSupport } from '@wordpress/blocks';
import { __, sprintf } from '@wordpress/i18n';
import { processCSSNesting } from '@wordpress/global-styles-engine';
import { useBlockEditingMode } from '../components/block-editing-mode';

/**
* Internal dependencies
Expand All @@ -33,6 +34,11 @@ const EMPTY_STYLE = {};
* @param {Object} props.style Block style attribute.
*/
function CustomCSSControl( { blockName, setAttributes, style } ) {
const blockEditingMode = useBlockEditingMode();

if ( blockEditingMode !== 'default' ) {
return null;
}
const blockType = getBlockType( blockName );

function onChange( newStyle ) {
Expand Down
4 changes: 2 additions & 2 deletions test/e2e/specs/site-editor/navigation-editor.spec.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -107,10 +107,10 @@ test.describe( 'Editing Navigation Menus', () => {
sidebar.getByRole( 'tab', { name: 'Document Overview' } )
).toBeHidden();

// The Settings tab is visible due to Custom CSS support.
await expect(
sidebar.getByRole( 'tab', { name: 'Settings' } )
).toBeVisible();
).toBeHidden();

await expect(
sidebar.getByRole( 'tab', { name: 'Styles' } )
).toBeHidden();
Expand Down
Loading