Skip to content

Fix "should undo bold" flaky test #76464

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
alecgeatches merged 2 commits into from
Mar 12, 2026
Merged

Fix "should undo bold" flaky test #76464

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
2253cc8
Wait for deferred bold action to complete in undo test
alecgeatches Mar 12, 2026
75189d2
Add comment about the workaround
alecgeatches Mar 12, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 13 additions & 0 deletions test/e2e/specs/editor/various/undo.spec.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -177,6 +177,19 @@ test.describe( 'undo', () => {
await editor.canvas.locator( '[data-type="core/paragraph"]' ).click();
await pageUtils.pressKeys( 'primary+a' );
await pageUtils.pressKeys( 'primary+b' );

// Real-time collaboration causes block CRDT content to be updated
// asynchronously, and the RTC undo manager relies on up-to-date CRDT
// content. Ensure the bold has been applied before trying to undo.
await expect.poll( editor.getBlocks ).toMatchObject( [
{
name: 'core/paragraph',
attributes: {
content: '<strong>test</strong>',
},
},
] );

await pageUtils.pressKeys( 'primary+z' );
await expect.poll( editor.getBlocks ).toMatchObject( [
{
Expand Down
Loading