Skip to content

RTC: Place sync connection modal in front of popover #76431

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
t-hamano merged 1 commit into from
Mar 12, 2026
Merged

RTC: Place sync connection modal in front of popover #76431

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions packages/base-styles/_z-index.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -137,6 +137,7 @@ $z-layers: (
".editor-post-template__swap-template-modal": 1000001,
".editor-post-template__create-template-modal": 1000001,
".edit-site-template-panel__replace-template-modal": 1000001,
".editor-sync-connection-modal": 1000001,

// Note: The ConfirmDialog component's z-index is being set to 1000001 in packages/components/src/confirm-dialog/styles.ts
// because it uses emotion and not sass. We need it to render on top its parent popover.
Expand Down
2 changes: 1 addition & 1 deletion packages/editor/src/components/sync-connection-modal/index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -146,7 +146,7 @@ export function SyncConnectionModal() {
return (
<BlockCanvasCover.Fill>
<Modal
className="editor-sync-connection-modal"
overlayClassName="editor-sync-connection-modal"
isDismissible={ false }
onRequestClose={ () => {} }
shouldCloseOnClickOutside={ false }
Expand Down
5 changes: 5 additions & 0 deletions packages/editor/src/components/sync-connection-modal/style.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,9 @@
@use "@wordpress/base-styles/colors" as *;
@use "@wordpress/base-styles/z-index" as *;

.editor-sync-connection-modal {
z-index: z-index(".editor-sync-connection-modal");
}

.editor-sync-connection-modal p {
margin: 0;
Expand Down
Loading